Skip to content

Add padding option #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kurkle merged 2 commits into from
Sep 1, 2021
Merged

Add padding option #53

kurkle merged 2 commits into from
Sep 1, 2021

Conversation

@stockiNail
Copy link
Contributor

@stockiNail stockiNail commented Sep 1, 2021

Fixes #50

@stockiNail
Copy link
Contributor Author

stockiNail commented Sep 1, 2021 •
edited
Loading

Thinking more about padding, previously was set to 7.5. 7.5 was half of textHeight (which was set to 15, before PR #48), therefore I'm going to change the code maintaining the same logic, using half of textHeight as default.

@kurkle kurkle added the enhancement New feature or request label Sep 1, 2021
@kurkle kurkle added this to the 0.8.0 milestone Sep 1, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kurkle kurkle merged commit a0ff4c5 into kurkle:master Sep 1, 2021
@stockiNail stockiNail deleted the paddingOption branch September 2, 2021 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kurkle kurkle kurkle approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

0.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@stockiNail @kurkle