Skip to content

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Sep 15, 2025

Summary by CodeRabbit

  • Bug Fixes

  • Chores

    • Released version 29.4.2.
    • Updated the changelog to document this release and its fix.

Copy link

coderabbitai bot commented Sep 15, 2025

Walkthrough

Adds a 29.4.2 release entry to CHANGELOG.md noting a Node 14 compatibility bug fix and updates package.json to version 29.4.2, introducing a new devDependency: conventional-changelog-angular.

Changes

Cohort / File(s) Change Summary
Release notes update
CHANGELOG.md
Added release entry 29.4.2 (2025-09-15) with a Bug Fixes item: Node 14 compatibility (commit aa0d563), referencing issue #5038.
Version bump & tooling
package.json
Bumped version from 29.4.1 to 29.4.2; added conventional-changelog-angular at ^8.0.0 under devDependencies.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • kulshekhar

Poem

A hop, a bump—version two-four-two,
Changelog squeaks, “Node 14, we’re through!”
Carrot-shaped commits in a tidy row,
Angular notes help the releases flow.
Thump of paws, I sign this fix—
Bunny-approved semantic tricks. 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "chore(release): 29.4.2" is a concise, single-line semantic commit-style message that directly reflects the primary change in this PR — a release bump to version 29.4.2 and the associated changelog and package.json updates. It is fully related to the changeset described in the raw_summary and pr_objectives and gives clear context for a teammate scanning history. The title avoids noise and is appropriately succinct for a release chore.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch release/29.4.2

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aa0d563 and ede9895.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • package.json (2 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: ahnpnl
PR: kulshekhar/ts-jest#4976
File: examples/js-with-babel/package.json:14-19
Timestamp: 2025-08-05T08:03:52.583Z
Learning: ts-jest version 29 supports both Jest 29 and Jest 30, so having ts-jest 29.x with Jest 30.x is not a compatibility issue and should not be flagged as a version mismatch problem.
📚 Learning: 2025-08-05T08:03:52.583Z
Learnt from: ahnpnl
PR: kulshekhar/ts-jest#4976
File: examples/js-with-babel/package.json:14-19
Timestamp: 2025-08-05T08:03:52.583Z
Learning: ts-jest version 29 supports both Jest 29 and Jest 30, so having ts-jest 29.x with Jest 30.x is not a compatibility issue and should not be flagged as a version mismatch problem.

Applied to files:

  • CHANGELOG.md
  • package.json
🔇 Additional comments (3)
package.json (2)

3-3: Approve: version bump matches changelog.
package.json version is 29.4.2 and CHANGELOG.md contains the corresponding "## 29.4.2 (2025-09-15)" entry — no concerns.


117-117: Approve — preset dependency added; verify installation

package.json contains "conventional-changelog-angular": "^8.0.0" (line 117) and package-lock.json lists v8.0.0, so the change matches the changelog script (-p angular). The sandbox has no node_modules (require.resolve failed), so verify locally or in CI by running:

npm ci
npx --yes conventional-changelog-cli -V
node -e "require.resolve('conventional-changelog-angular/package.json'); console.log('preset ok')"

CHANGELOG.md (1)

1-8: Fix CHANGELOG: incorrect issue reference & heading-level nit

Likely an incorrect or invalid review comment.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@ahnpnl ahnpnl marked this pull request as ready for review September 15, 2025 18:14
@ahnpnl ahnpnl requested a review from kulshekhar as a code owner September 15, 2025 18:14
@ahnpnl ahnpnl merged commit 111a737 into main Sep 15, 2025
21 checks passed
@ahnpnl ahnpnl deleted the release/29.4.2 branch September 15, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants