Add support for cumprod #419
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
DenisVieriu97
commented
Apr 18, 2023
DenisVieriu97
commented
- Add support for cumprod.
- Extend cumsum testcase to test cumprod.
DenisVieriu97
requested review from
Ronian526,
kulinseth,
razarmehr,
shuhand0,
skotapati and
ssaladis
|
There's this failure though on MacOS 12.5: |
kulinseth
requested changes
Apr 18, 2023
Owner
There was a problem hiding this comment.
@DenisVieriu97 , can you just go ahead and add , cummin and cummax as well ?
Collaborator
Author
I'll take a look |
kulinseth
reviewed
May 24, 2023
DenisVieriu97
force-pushed
the
dev/denis/cumulative_ops
branch
from
e32c78c to
f897912
Compare
kulinseth
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.