-
Notifications
You must be signed in to change notification settings - Fork 9
add BatchOp, NfftOp, WaveletOp, partial-CUDA compatibility, and some optimizations #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…emove BroadcastingDiagOp
|
@hakkelt I don’t think I have the resources to keep maintaining this package. We could think of option 2 maybe? |
|
Hey @hakkelt sorry for the late reply. I also don't have the bandwidth to review this PR and I think option 2 is fine with me. I'll grant you the permission! |
|
Thank you both! |
1) interface changes: domainType -> domain_type, codomainType -> codomain_type 2) separate operators with dependencies (DSP, FFTW, NFFT, Wavelets) 3) expose levels in WaveletOperators 4) Fix errors and improve BatchOps 5) Improve performance with FastBroadcast's @.. macro and Polyester's @Batch 6) Fix errors in documentation
|
This PR contains the following breaking changes:
Please, let me know if you have objections to any of these changes or need clarification. Otherwise I plan to merge this PR in a week or so. |
This is an admittedly large pull request with many new features and substantial changes. My main question is what your plans are with the package: Are you still intending to actively maintain it in the future, do you want to reserve it only for bugfixes, or are you open, maybe, to add me as a maintainer? I started to work heavily on this package and the connected packages (ProximalOperators.jl, ProximalAlgorithms.jl, StructuredOptimization.jl), so many substantial PRs are to be expected from my side. I can see 3 scenarios that might work out for me:
I hope you will have spare time for the cooperation, and I hope for either option 1 or 2. But I also need to proceed with my work (I work on this project as part of my PhD studies), so an answer for this would be helpful. :)