Skip to content

feat: add role dependency #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025
Merged

Conversation

redscholar
Copy link
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adding role dependencies
You can define dependencies in roles/{role}/meta/main.yaml:

|-- roles/
|  |-- meta/
|  |  |-- main.yaml

Example:

dependencies:
  - role: other_role
image

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

add role dependency

Additional documentation, usage docs, etc.:


@kubesphere-prow kubesphere-prow bot added release-note kind/feature Categorizes issue or PR as related to a new feature. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 9, 2025
@redscholar redscholar force-pushed the feature branch 2 times, most recently from 7a9baa7 to ee09744 Compare July 9, 2025 06:43
Copy link

sonarqubecloud bot commented Jul 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
20.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@pixiake
Copy link
Collaborator

pixiake commented Jul 9, 2025

/lgtm
/approve

@kubesphere-prow kubesphere-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2025
Copy link

LGTM label has been added.

Git tree hash: 40a835686ea321a61f8f43b9013cf4c7a1eb0d20

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixiake, redscholar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pixiake pixiake merged commit e5077f5 into kubesphere:feature-gitops Jul 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants