Skip to content

Conversation

redscholar
Copy link
Contributor

@redscholar redscholar commented Jun 23, 2025

What type of PR is this?

What this PR does / why we need it:

Add command kk delete image_registry with the following specifications:

  1. Only supports deleting the image_registry that was created by Kubekey (must have deleteImageRegistry set to true).
  2. Add image_registry deletion logic to both kk delete nodes and kk delete cluster.

test results:
image

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

add command: kk delete image_registry

Additional documentation, usage docs, etc.:


Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redscholar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubesphere-prow kubesphere-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note and removed do-not-merge/release-note-label-needed labels Jun 23, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
19.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@pixiake pixiake merged commit a306bd6 into kubesphere:feature-gitops Jun 23, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants