Skip to content

Conversation

yhan219
Copy link
Contributor

@yhan219 yhan219 commented May 13, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewers:

When downloading offline, it often timed out. Now it is set to 2 hours. Although it is already very long, the time is still not enough if you rely on all the downloads, so it will be extended to 5 hours.

Does this PR introduced a user-facing change?

DefaultTimeout 2h->5h

Additional documentation, usage docs, etc.:


Copy link

Welcome @yhan219! It looks like this is your first PR to kubesphere/kubekey 🎉

@kubesphere-prow kubesphere-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 13, 2025
@redscholar
Copy link
Contributor

@yhan219 you can fix DCO check by run command in your branch

git commit -s --no-edit --amend
git push -f

Copy link

@redscholar
Copy link
Contributor

/approve
/lgtm

@kubesphere-prow kubesphere-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2025
Copy link

LGTM label has been added.

Git tree hash: 8994c2cecaca25a2931e9120b58fd994cc638bc0

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redscholar, yhan219

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubesphere-prow kubesphere-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2025
@kubesphere-prow kubesphere-prow bot merged commit c4301c0 into kubesphere:master May 13, 2025
6 checks passed
@pixiake
Copy link
Collaborator

pixiake commented Jun 12, 2025

@all-contributors please add @yhan219 for code

Copy link
Contributor

@pixiake

I've put up a pull request to add @yhan219! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants