Skip to content

Conversation

redscholar
Copy link
Contributor

@redscholar redscholar commented May 13, 2025

What type of PR is this?

/kind deprecation

What this PR does / why we need it:

  • hostvars: A map[string]interface{} that stores all host variables, where the key is the inventory_hostname and the value represents the actual variables.
  • inventory_hostname: Stores the specific node name as defined in inventory.yaml.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

change inventory_hosts to hostvars
change inventory_name to inventory_hostname

Additional documentation, usage docs, etc.:


Copy link

@redscholar: The label(s) kind/deprecation cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind deprecation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

change inventory_hosts to hostvars

Additional documentation, usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redscholar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubesphere-prow kubesphere-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 13, 2025
@redscholar redscholar changed the title feat: change inventory_hosts to hostvars feat: change builtin defined variablename May 13, 2025
@redscholar redscholar changed the title feat: change builtin defined variablename feat: change builtin defined variable May 13, 2025
Copy link

This PR has multiple commits, and the default merge method is: squash.
You can request commits to be merged using the label: tide/merge-method-merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

@liangzai006
Copy link
Contributor

/lgtm

@kubesphere-prow kubesphere-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2025
Copy link

LGTM label has been added.

Git tree hash: c31d7cbd7b488a8a2ecc24778b81593bcaf8316d

@kubesphere-prow kubesphere-prow bot merged commit fb474bd into kubesphere:feature-gitops May 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants