Skip to content

feat: add gather_facts cache #2558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

redscholar
Copy link
Collaborator

@redscholar redscholar commented May 9, 2025

What type of PR is this?

What this PR does / why we need it:

Add the fact_caching variable. Supported options: jsonfile, yamlfile, memory, or "" (empty string).

  • jsonfile: Caches gathered facts locally at <workdir>/runtime/gather_facts_caches/<inventory_name>.json
  • yamlfile: Caches gathered facts locally at <workdir>/runtime/gather_facts_caches/<inventory_name>.yaml
  • memory: Caches facts in memory
  • "" (empty string): Disables caching and clears existing cache

test results:
image
image
image

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

add gather_facts cache

Additional documentation, usage docs, etc.:


Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redscholar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubesphere-prow kubesphere-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 9, 2025
@redscholar redscholar force-pushed the feature branch 2 times, most recently from 461f1ff to 29a3078 Compare May 9, 2025 10:03
@redscholar redscholar force-pushed the feature branch 2 times, most recently from 355065f to 66d2d05 Compare May 12, 2025 05:52
Copy link

@pixiake
Copy link
Collaborator

pixiake commented May 12, 2025

/lgtm

@kubesphere-prow kubesphere-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2025
Copy link

LGTM label has been added.

Git tree hash: f25434023f06b8086c6ca4834aca9b1d43c5b32b

@kubesphere-prow kubesphere-prow bot merged commit 13df73e into kubesphere:feature-gitops May 12, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants