Fix(connector): gracefully handle LANG environment setup failures-Update ssh.go #2552
Conversation
|
Welcome @zmoon460! It looks like this is your first PR to kubesphere/kubekey 🎉 |
kubesphere-prow
bot
added
the
size/XS
|
This PR has multiple commits, and the default merge method is: squash. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
kubesphere-prow
bot
added
size/S
|
操作失误，把另外一个issue的 PR 的修复也 放进来了： |
|
git commit -s --no-edit --amend
git push -f |
zmoon460
force-pushed
the
zmoon460-patch-sshgo.1
branch
2 times, most recently
from
88d5107 to
32a4216
Compare
setenv 会导致在kk 3.1.8/3.1.9 在centos/rockey linux 9.x下ssh fail ，无法部署； 经过验证，不设置语言对在centos/rockey linux 9.x部署没有影响，建议setenv改为尽力而为方式更合适，，设置失败产生Warn即可。 Signed-off-by: zmoon460 <[email protected]>
修改Setenv告警日志显示 Localization warning 为Warning ，更符合一般习惯 Signed-off-by: zmoon460 <[email protected]>
Check chown operator Signed-off-by: zmoon460 <[email protected]>
部署测试模拟发现，如果设置失败会大量产生这种Warning，可能因为部署过程kk有大量ssh连接操作的缘故，故降到Debug级别 Co-Authored-By: zmoon460 <[email protected]> Signed-off-by: zmoon460 <[email protected]>
zmoon460
force-pushed
the
zmoon460-patch-sshgo.1
branch
from
32a4216 to
558a386
Compare
|
kubesphere-prow
bot
added
release-note
and removed
do-not-merge/release-note-label-needed
labels
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: redscholar, zmoon460 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 3ea4ec7a0fd73692cdf6cca582a42bd860af6626
|
kubesphere-prow
bot
added
the
approved
|
/cherry-pick master |
|
@redscholar: new pull request created: #2554 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@all-contributors please add @zmoon460 for code |
|
I've put up a pull request to add @zmoon460! 🎉 |
Fix(connector): gracefully handle LANG environment setup failures
What this PR does / why we need it:
setenv 操作导致在kk 3.1.8/3.1.9 在centos/rockey linux 9.x下ssh fail ，导致无法正常部署； 经过验证不设置语言对在centos/rockey linux 9.x部署没有影响，建议setenv改为尽力而为方式更合适，失败情况下产生Warn即可。
Which issue(s) this PR fixes:
Fixes #2546
(#2546)
引入问题的原始pull， 影响3.1.7后面的所有版本
#2489