Skip to content

feat(addon): add yaml values to render yaml files, like helm values #2498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

jojotong
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

addon support yaml values to render yaml files, like helm values:

- name: xxx                  # the name of addon
  namespace: xxx             # namespace
  sources:                    # support both yaml and chart
    chart:                          
      name: xxx              # the name of chart
      repo:  xxx             # the name of chart repo (url)
      path: xxx              # the location of chart  (path)
      values:  xxx           # specify values for chart (string list)
      valuesFile: xxx        # specify values file for chart (path / url)
    yaml: 
      path: []               # the location list of yaml (path / url) 
      values:                # custom variables like helm values (not nessesary)
        key1: xxx
        map1:
          subkey1: xxx

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


Copy link

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubesphere-prow kubesphere-prow bot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 20, 2025
Copy link

@redscholar
Copy link
Collaborator

/lgtm
/approve

@kubesphere-prow kubesphere-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2025
Copy link

LGTM label has been added.

Git tree hash: ae127a0df567c48c3a7dc19ee9ae96cbceffb41b

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jojotong, redscholar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubesphere-prow kubesphere-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2025
@kubesphere-prow kubesphere-prow bot merged commit b49d121 into kubesphere:master Feb 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/release-note-label-needed kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants