Skip to content

Add presubmit job for ibm test-infra and move preset label to config file #34667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

Add presubmit job for ibm test-infra and move preset label to config file #34667

merged 1 commit into from
Apr 10, 2025

Conversation

Rajalakshmi-Girish
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/testgrid sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 10, 2025
mkumatag
mkumatag approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2025
@mkumatag
Copy link
Member

@Rajalakshmi-Girish fix teh lint issues

@Rajalakshmi-Girish Rajalakshmi-Girish force-pushed the presubmit-provider-ibmcloud branch from 3970fe4 to 8c6886c Compare April 10, 2025 14:45
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2025
mkumatag
mkumatag approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2025
@dims
Copy link
Member

dims commented Apr 10, 2025

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, mkumatag, Rajalakshmi-Girish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit 03a44f6 into kubernetes:master Apr 10, 2025
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@Rajalakshmi-Girish: Updated the following 2 configmaps:

  • job-config configmap in namespace default at cluster test-infra-trusted using the following files:
    • key cloud-provider-ibmcloud-periodics.yaml using file config/jobs/kubernetes/cloud-provider-ibmcloud/cloud-provider-ibmcloud-periodics.yaml
    • key cloud-provider-ibmcloud-presubmits.yaml using file config/jobs/kubernetes/cloud-provider-ibmcloud/cloud-provider-ibmcloud-presubmits.yaml
  • config configmap in namespace default at cluster test-infra-trusted using the following files:
    • key config.yaml using file config/prow/config.yaml

In response to this:

Adding an optional presubmit job by name pull-provider-ibmcloud-test-infra-kubernetes to test the PRs to https://github.com/kubernetes-sigs/provider-ibmcloud-test-infra.

Internal job that ran with these configurations PASSED https://prow.ppc64le-cloud.cis.ibm.net/view/s3/ppc64le-prow-logs/pr-logs/pull/kubernetes-sigs_provider-ibmcloud-test-infra/22/pull-provider-ibmcloud-test-infra-kubernetes/1909950991529152512

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Rajalakshmi-Girish Rajalakshmi-Girish mentioned this pull request Apr 17, 2025
Open
14 tasks
@mkumatag mkumatag mentioned this pull request Jul 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cblecker cblecker Awaiting requested review from cblecker

@dims dims Awaiting requested review from dims

@MadhavJivrajani MadhavJivrajani Awaiting requested review from MadhavJivrajani

@Priyankasaggu11929 Priyankasaggu11929 Awaiting requested review from Priyankasaggu11929

1 more reviewer

@mkumatag mkumatag mkumatag approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dims dims

@mkumatag mkumatag

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Rajalakshmi-Girish @mkumatag @dims @k8s-ci-robot