Skip to content

Conversation

aojea
Copy link
Member

@aojea aojea commented Mar 24, 2025

The Slow tag is not used consistently, and in periodics we should not worry too much about slow unless there is a significant penalty, but since all test run in parallel, it should not be very impactful.

Fortunately, I had another set of alpha beta kind jobs running those slows, and these caught the flake on this test kubernetes/kubernetes#131011 , we should run slow in our informing. periodic jobs too to not miss this signal

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config labels Mar 24, 2025
@k8s-ci-robot k8s-ci-robot requested a review from chases2 March 24, 2025 08:22
@k8s-ci-robot k8s-ci-robot requested a review from wojtek-t March 24, 2025 08:22
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Mar 24, 2025
@aojea
Copy link
Member Author

aojea commented Mar 24, 2025

/assign @pohly @BenTheElder @dims @wendy-ha18

Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fortunately, I had another set of alpha beta kind jobs running those slows, and these caught the flake on this test kubernetes/kubernetes#131011

Good catch!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 14890ef into kubernetes:master Mar 24, 2025
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@aojea: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubernetes-kind.yaml using file config/jobs/kubernetes/sig-testing/kubernetes-kind.yaml

In response to this:

The Slow tag is not used consistently, and in periodics we should not worry too much about slow unless there is a significant penalty, but since all test run in parallel, it should not be very impactful.

Fortunately, I had another set of alpha beta kind jobs running those slows, and these caught the flake on this test kubernetes/kubernetes#131011 , we should run slow in our informing. periodic jobs too to not miss this signal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BenTheElder
Copy link
Member

@BenTheElder
Copy link
Member

however most are passing, so overall I do think we should do this. but we'll need to clean this up for the release signal

tentatively a few flaky test cases (versus eg overall job timeout)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants