-
Notifications
You must be signed in to change notification settings - Fork 2.8k
run slow tests on kind alpha beta periodics #34584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/assign @pohly @BenTheElder @dims @wendy-ha18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fortunately, I had another set of alpha beta kind jobs running those slows, and these caught the flake on this test kubernetes/kubernetes#131011
Good catch!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@aojea: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
These are failing :( https://testgrid.k8s.io/sig-release-master-informing#kind-master-beta |
however most are passing, so overall I do think we should do this. but we'll need to clean this up for the release signal tentatively a few flaky test cases (versus eg overall job timeout) |
The Slow tag is not used consistently, and in periodics we should not worry too much about slow unless there is a significant penalty, but since all test run in parallel, it should not be very impactful.
Fortunately, I had another set of alpha beta kind jobs running those slows, and these caught the flake on this test kubernetes/kubernetes#131011 , we should run slow in our informing. periodic jobs too to not miss this signal