document --insecure-registry flag #1047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Collaborator
|
Can one of the admins verify this patch? |
bacongobbler
force-pushed
the
document-insecure-registry
branch
from
25f319e to
bd2e1c0
Compare
Current coverage is 34.65% (diff: 100%)@@ master #1047 diff @@
==========================================
Files 43 43
Lines 2000 2000
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 693 693
Misses 1170 1170
Partials 137 137
|
r2d4
reviewed
Jan 26, 2017
README.md
Outdated
| `minikube start` command to enable insecure communication between the docker engine and registries listening to reqeusts from the CIDR range. | ||
|
|
||
| One nifty hack is to allow the kubelet running in minikube to talk to registries deployed inside a pod in the cluster without backing them | ||
| with TLS certificates. Because the service cluster IP range is known to be available at 10.0.0.0/24, users can pull images from registries |
Contributor
There was a problem hiding this comment.
small nit: I think its 10.0.0.1?
minikube/pkg/util/constants.go
Line 23 in a403a94
Contributor
Author
There was a problem hiding this comment.
Nice catch. I'll fix that/make it more clear :)
bacongobbler
force-pushed
the
document-insecure-registry
branch
from
bd2e1c0 to
63bd5d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1046