Skip to content

Conversation

hakman
Copy link
Member

@hakman hakman commented Jul 29, 2025

Broken in 553509b

-       return fmt.Sprintf("%v.%v", jobName, suffix), nil
+
+       if suffix != "" {
+               jobName = jobType + "." + suffix
+       }
+
+       return jobName, nil

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 29, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 29, 2025
@hakman hakman removed request for johngmyers and zetaab July 29, 2025 05:10
@hakman
Copy link
Member Author

hakman commented Jul 29, 2025

/cc @rifelpet @ameukam

@k8s-ci-robot k8s-ci-robot requested review from ameukam and rifelpet July 29, 2025 05:10
@hakman hakman force-pushed the fix-e2e-job-name branch 2 times, most recently from 813bb1d to 297e13c Compare July 29, 2025 05:20
@hakman
Copy link
Member Author

hakman commented Jul 29, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2025
@hakman
Copy link
Member Author

hakman commented Jul 29, 2025

All tests failed due to the broken test, updating regex...

@hakman hakman force-pushed the fix-e2e-job-name branch 2 times, most recently from 4639561 to 98ef088 Compare July 29, 2025 07:53
@hakman hakman force-pushed the fix-e2e-job-name branch from 98ef088 to 04e6c19 Compare July 29, 2025 07:53
@hakman
Copy link
Member Author

hakman commented Jul 29, 2025

All tests passing, ready to merge.

@ameukam
Copy link
Member

ameukam commented Jul 29, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5a0fce0 into kubernetes:master Jul 29, 2025
27 checks passed
@hakman hakman deleted the fix-e2e-job-name branch July 29, 2025 09:52
k8s-ci-robot added a commit that referenced this pull request Aug 1, 2025
…-upstream-release-1.32

Automated cherry pick of #17523: testing: Fix e2e test job name
k8s-ci-robot added a commit that referenced this pull request Aug 1, 2025
…-upstream-release-1.33

Automated cherry pick of #17523: testing: Fix e2e test job name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants