Skip to content

azure: Track resources by ID during deletion #17493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2025
Merged

azure: Track resources by ID during deletion #17493

merged 1 commit into from
Jul 12, 2025

Conversation

hakman
Copy link
Member

@hakman hakman commented Jul 12, 2025

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot requested review from ameukam and rifelpet July 12, 2025 14:27
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 12, 2025
@hakman hakman marked this pull request as ready for review July 12, 2025 14:27
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/provider/azure Issues or PRs related to azure provider and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 12, 2025
@hakman hakman force-pushed the azure-delete-by-resourceid branch from 7c27cda to 40f0567 Compare July 12, 2025 15:32
@hakman hakman force-pushed the azure-delete-by-resourceid branch from 40f0567 to f742fff Compare July 12, 2025 15:43
@ameukam
Copy link
Member

ameukam commented Jul 12, 2025

/lgtm
(we really need to think about e2e tests on Azure)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2025
@hakman
Copy link
Member Author

hakman commented Jul 12, 2025

/lgtm (we really need to think about e2e tests on Azure)

@ameukam Let's chat next week

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2025
@k8s-ci-robot k8s-ci-robot merged commit ac33de5 into kubernetes:master Jul 12, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameukam ameukam Awaiting requested review from ameukam

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hakman @k8s-ci-robot @ameukam