Skip to content

Conversation

rifelpet
Copy link
Member

Fixes #17421

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/provider/aws Issues or PRs related to aws provider labels Jun 12, 2025
@k8s-ci-robot k8s-ci-robot requested review from hakman and zetaab June 12, 2025 03:57
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 12, 2025
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 1111716 into kubernetes:master Jun 12, 2025
25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Jun 12, 2025
@rifelpet rifelpet modified the milestones: v1.32, v1.33 Jun 23, 2025
@homie-du
Copy link

homie-du commented Jul 17, 2025

@rifelpet @hakman

I’m on kops v1.32.1. kops get assets --copy still fails because kOps calls DescribeSecurityGroupRules with the unsupported vpc-id filter.

Error: error running tasks: deadline exceeded executing task SecurityGroup/api-elb.homie-test.com. Example error: operation error EC2: DescribeSecurityGroupRules, https response error StatusCode: 400, RequestID: efffabdb-fe73-411e-8415-b6557d0246eb, api error InvalidParameterValue: The filter 'vpc-id' is invalid

According to the AWS SDK, DescribeSecurityGroupRules only accepts three filters:

  • group-id
  • security-group-rule-id
  • tag:<key>

Please cherry-pick commit ca9fa29 (from PR #17432) to release-1.32 and drop the vpc-id filter so v1.32 users can mirror assets without this error.

Thanks!

@diane-devops
Copy link

diane-devops commented Jul 18, 2025

@rifelpet @hakman
DescribeSecurityGroupRulesInput type does not allow vpc-id and group-name in filters.
Security group IDs are unique in all of accounts, specifying just the security group ID should be enough.

https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/ec2#DescribeSecurityGroupRulesInput

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kops get assets gives panic: runtime error: invalid memory address or nil pointer dereference
6 participants