Skip to content

Conversation

h3poteto
Copy link
Contributor

@h3poteto h3poteto commented Jun 8, 2025

fix #17250

This feature is documented: https://github.com/kubernetes/kops/blob/v1.32.0/docs/bastion.md#additional-security-groups-to-elb
But it is not implemented.

Once this feature was added: #8921
However, this was removed: #14468

I guess

So, I think we can re-enable this feature currently.

What do you think?
If we don't need this feature, I'm going to delete it from the document.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 8, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @h3poteto. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested review from hakman and zetaab June 8, 2025 12:28
@k8s-ci-robot k8s-ci-robot added area/api area/provider/aws Issues or PRs related to aws provider labels Jun 8, 2025
@h3poteto h3poteto force-pushed the iss-17250/additional-security-groups branch from c4abafd to 86e40d7 Compare June 8, 2025 12:49
@h3poteto h3poteto force-pushed the iss-17250/additional-security-groups branch from 86e40d7 to b674f78 Compare June 8, 2025 13:07
@hakman
Copy link
Member

hakman commented Jun 8, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 8, 2025
@hakman
Copy link
Member

hakman commented Jun 8, 2025

Thanks @h3poteto, looks good to me as is.
/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2025
@hakman
Copy link
Member

hakman commented Jun 8, 2025

/test pull-kops-e2e-k8s-gce-cilium
/test pull-kops-e2e-k8s-gce-ipalias

@hakman
Copy link
Member

hakman commented Jun 8, 2025

/override pull-kops-e2e-k8s-gce-ipalias

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-gce-ipalias

In response to this:

/override pull-kops-e2e-k8s-gce-ipalias

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit b1081c4 into kubernetes:master Jun 8, 2025
26 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Jun 8, 2025
@rifelpet rifelpet modified the milestones: v1.32, v1.33 Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

additionalSecurityGroups for bastion ELB is documented but isn't implemented
4 participants