-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Re-enable additionalSecurityGroups for bastion LB #17430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable additionalSecurityGroups for bastion LB #17430
Conversation
Hi @h3poteto. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
c4abafd
to
86e40d7
Compare
86e40d7
to
b674f78
Compare
/ok-to-test |
Thanks @h3poteto, looks good to me as is. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kops-e2e-k8s-gce-cilium |
/override pull-kops-e2e-k8s-gce-ipalias |
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-gce-ipalias In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
fix #17250
This feature is documented: https://github.com/kubernetes/kops/blob/v1.32.0/docs/bastion.md#additional-security-groups-to-elb
But it is not implemented.
Once this feature was added: #8921
However, this was removed: #14468
I guess
So, I think we can re-enable this feature currently.
What do you think?
If we don't need this feature, I'm going to delete it from the document.