Skip to content

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Sep 16, 2019

Add node selectors to support clustes with windows nodes.

A copy of #4138 given that that PR does not have a CLA signed @maciaszczykm asked me to make the change as a new PR.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 16, 2019
@pjbgf
Copy link
Member Author

pjbgf commented Sep 16, 2019

/assign @PeWu

@jeefy
Copy link
Member

jeefy commented Sep 16, 2019

Travis job flaked because of jasmine, restarting.

@codecov
Copy link

codecov bot commented Sep 16, 2019

Codecov Report

Merging #4292 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4292   +/-   ##
=======================================
  Coverage   46.62%   46.62%           
=======================================
  Files         200      200           
  Lines        9373     9373           
  Branches      105      105           
=======================================
  Hits         4370     4370           
  Misses       4734     4734           
  Partials      269      269

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 939857b...ecaf7b4. Read the comment docs.

@jeefy
Copy link
Member

jeefy commented Sep 16, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeefy, pjbgf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit d9b14ee into kubernetes:master Sep 16, 2019
@pjbgf pjbgf deleted the node-selection branch September 16, 2019 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants