Skip to content

Conversation

@yue9944882
Copy link
Member

Cherry pick of #1146 #1157 #1169 #1177 on release-1.29.

#1146: upgraded to ec2 v2, buggy
#1157: Update ELB and ELBV2 packages to AWS SDK Go V2
#1169: aws sdk go upgrade
#1177: update aws & awserr to go sdk v2

Also manually applied changes to upgrade ECR and Autoscaling usage to aws sdk go v2. The changes to ECR are in files

cmd/ecr-credential-provider/main.go
cmd/ecr-credential-provider/main_test.go
pkg/mocks/mock_ecr.go
and the changes to autoscaling are in files
pkg/providers/v1/aws_sdk.go (client creation code)
pkg/providers/v1/config.go (helper functions for client creation)
For details on the cherry pick process, see the cherry pick requests page.

Migrate to AWS SDK Go V2

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 10, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 10, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 10, 2025
@yue9944882 yue9944882 force-pushed the 1.29-ccm-sdk-v2 branch 2 times, most recently from 1003809 to 7d5499c Compare November 10, 2025 19:44
@yue9944882 yue9944882 changed the title Automated cherry pick of #1146: upgraded to ec2 v2, buggy #1157: Update ELB and ELBV2 packages to AWS SDK Go V2 #1169: aws sdk go upgrade #1177: update aws & awserr to go sdk v2 (1.29) Automated cherry pick of #1146: upgraded to ec2 v2, buggy #1157: Update ELB and ELBV2 packages to AWS SDK Go V2 #1169: aws sdk go upgrade #1177: update aws & awserr to go sdk v2 Nov 10, 2025
@kmala
Copy link
Member

kmala commented Nov 12, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kmala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2025
@k8s-ci-robot k8s-ci-robot merged commit e064d0c into kubernetes:release-1.29 Nov 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants