-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Hetzner(feat): add option to set nodepool-specific image IDs #8297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hetzner(feat): add option to set nodepool-specific image IDs #8297
Conversation
|
Welcome @pat-s! |
|
Hi @pat-s. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/assign @apricote |
|
@apricote Sorry for the ping, just asking if this PR made it to your backlog via the assignment? |
Hey, apologies for the long wait. We kinda missed it. I will have a look at the PR. |
|
/lgtm |
|
@lukasmetzner: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Thank you @pat-s /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apricote, pat-s The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Allows setting nodepool-specific image IDs instead of sharing a global default across all nodepools.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Yes