Skip to content

Upgrade go to 1.22 #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2024
Merged

Upgrade go to 1.22 #1262

merged 2 commits into from
Apr 2, 2024

Conversation

@cpanato
Copy link
Member

@cpanato cpanato commented Mar 31, 2024

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

  • Upgrade go to 1.22

/assign @puerco @saschagrunert @xmudrii
cc @kubernetes-sigs/release-engineering

/hold for test-infra job update

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Upgrade go to 1.22

@cpanato
upgrade go to 1.22
ad1c97a 
Signed-off-by: cpanato <[email protected]>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 31, 2024
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 31, 2024
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 31, 2024
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 31, 2024
@cpanato cpanato mentioned this pull request Mar 31, 2024
Merged
msfidelis
msfidelis reviewed Mar 31, 2024
View reviewed changes
@cpanato
fix lints
5132f50 
Signed-off-by: cpanato <[email protected]>
xmudrii
xmudrii approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2024
@cpanato
Copy link
Member Author

cpanato commented Apr 2, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 181f73b into kubernetes-sigs:main Apr 2, 2024
@cpanato cpanato deleted the upgrade-go branch April 2, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@xmudrii xmudrii xmudrii approved these changes

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@jrsapi jrsapi Awaiting requested review from jrsapi

+1 more reviewer

@msfidelis msfidelis msfidelis left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@saschagrunert saschagrunert

@puerco puerco

@xmudrii xmudrii

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cpanato @k8s-ci-robot @saschagrunert @msfidelis @xmudrii @puerco