chore: Deprecate Prometheus Adapter #703
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
This issue is currently awaiting triage. If prometheus-adapter contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-triage
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rexagod The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
Push KEDA's Prometheus, CPU, and Memory scalers instead. Signed-off-by: Pranshu Srivastava <[email protected]>
|
@rexagod: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/assign @dgrisonnet |
| - The examples below assume you are scaling a single Deployment named `my-app` in namespace `default`, and that your Prometheus instance is reachable at `http://prometheus.monitoring.svc:9090`. | ||
| - KEDA's query blocks do not support the templating syntax used in Prometheus Adapter. Instead, you need to write concrete queries that return a single number (instant vector with a single element or a scalar). | ||
| - The queries should be adapted to your environment, and you can use label selectors to narrow down the metrics to the specific pods or namespaces you are interested in (for example, `pod=~"my-app-.*"` and a fixed namespace). | ||
| - Unlike Prometheus Adapter, KEDA does not support defining [custom metrics](https://kubernetes.io/docs/reference/external-api/custom-metrics.v1beta2/), and as such, all newly mapped metrics for HPA consumption on KEDA's end are exposed as [external metrics](https://kubernetes.io/docs/reference/external-api/external-metrics.v1beta1/). |
There was a problem hiding this comment.
IMO, this seems like a blocker for deprecating it as we are using it for custom metrics
4 participants
Push KEDA's Prometheus, CPU, and Memory scalers instead.
Fixes: #701