Skip to content

fix: make private one field in replacements transformer struct that had a missing JSON tag #5877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2025
Merged

fix: make private one field in replacements transformer struct that had a missing JSON tag #5877

merged 1 commit into from
Apr 3, 2025

Conversation

tsuzu
Copy link
Contributor

@tsuzu tsuzu commented Mar 18, 2025 •
edited
Loading

Closes #5868

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 18, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 18, 2025
@tsuzu tsuzu mentioned this pull request Mar 18, 2025
Closed
@koba1t
Copy link
Member

koba1t commented Mar 27, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 27, 2025
@tsuzu tsuzu force-pushed the fix-replacements-plugin-omitempty-field branch from 2519829 to e3f0349 Compare March 31, 2025 11:41
@koba1t
Copy link
Member

koba1t commented Mar 31, 2025

/retitle fix: make private one field in replacements transformer struct that had a missing JSON tag

@k8s-ci-robot k8s-ci-robot changed the title Make replacements private fix: make private one field in replacements transformer struct that had a missing JSON tag Mar 31, 2025
@tsuzu tsuzu marked this pull request as ready for review March 31, 2025 17:52
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2025
@koba1t
Copy link
Member

koba1t commented Apr 2, 2025

/assign

@koba1t
Copy link
Member

koba1t commented Apr 3, 2025

Thanks @tsuzu !

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: koba1t, tsuzu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7372f97 into kubernetes-sigs:master Apr 3, 2025
11 checks passed
@Vasco-jofra Vasco-jofra mentioned this pull request Apr 21, 2025
Merged
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jun 29, 2025
@tmeijn
build(deps): update kubernetes-sigs/kustomize to v5.7.0
41b6b4b 
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [kubernetes-sigs/kustomize](https://github.com/kubernetes-sigs/kustomize) | minor | `v5.6.0` -> `v5.7.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>kubernetes-sigs/kustomize (kubernetes-sigs/kustomize)</summary>

### [`v5.7.0`](https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize/v5.7.0)

[Compare Source](kubernetes-sigs/kustomize@kustomize/v5.6.0...kustomize/v5.7.0)

#### Feature

kubernetes-sigs/kustomize#5630: Add static value source for replacement
kubernetes-sigs/kustomize#5921: feat: Add images suport for Image Volumes
kubernetes-sigs/kustomize#5771: fix: Allow patches with empty files with multiple newlines or comments
kubernetes-sigs/kustomize#5865: feat(helm): allow the use of devel alias for helmcharts

#### fix

kubernetes-sigs/kustomize#5846: fix: Get version from the BuildInfo.Main.Version if not found in deps and build flag
kubernetes-sigs/kustomize#5859: fix: Don't panic on multiple $patch: delete strategic merge patches in a single patch file
kubernetes-sigs/kustomize#5877: fix: make private one field in replacements transformer struct that had a missing JSON tag

#### Dependencies

[#&#8203;5847](kubernetes-sigs/kustomize#5847): replace deplecated package github.com/google/shlex with github.com/carapace-sh/carapace-shlex
[#&#8203;5873](kubernetes-sigs/kustomize#5873): Bump to github.com/spf13/viper v1.20.0
[#&#8203;5931](kubernetes-sigs/kustomize#5931): Drop usage of forked copies of goyaml.v2 and goyaml.v3

#### chore

kubernetes-sigs/kustomize#5882: Set Git messages to English for TestRemoteLoad\_LocalProtocol
[#&#8203;5934](kubernetes-sigs/kustomize#5934): Update kyaml to v0.20.0
[#&#8203;5935](kubernetes-sigs/kustomize#5935): Update cmd/config to v0.20.0
[#&#8203;5936](kubernetes-sigs/kustomize#5936): Update api to v0.20.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC42Mi4xIiwidXBkYXRlZEluVmVyIjoiNDAuNjIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncapps ncapps Awaiting requested review from ncapps

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

@stormqueen1990 stormqueen1990 Awaiting requested review from stormqueen1990

Assignees

@koba1t koba1t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON/YAML tag uses "omitempty" as the field name
3 participants
@tsuzu @k8s-ci-robot @koba1t