Enhancement for format error message #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
| Path: filepath, | ||
| ErrorMsg: errorMsg, | ||
| } | ||
| if testErr != expectErr { |
There was a problem hiding this comment.
Instead of using expectErr as a YamlFormatError, can you use an expected error message?
expected := "some expected error message"
if testErr.Error() != expected {
| @@ -119,7 +120,7 @@ func NewResourceSliceFromPatches( | |||
|
|
|||
| res, err := newResourceSliceFromBytes(content) | |||
| if err != nil { | |||
| return nil, err | |||
| return nil, internal.ErrorHandler(err, path) | |||
There was a problem hiding this comment.
There might be other places we parse YAML files and catch the error. Can you also apply this error handler for them?
fanzhangio
force-pushed
the
issue114
branch
2 times, most recently
from
f1a9bf4 to
ef57f40
Compare
| ` | ||
| ) | ||
|
|
||
| //type foo struct |
There was a problem hiding this comment.
move this line to the bottom？
- add yaml format error handler - silent usage when build command fails
Liujingfang1
approved these changes
Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error message on YAML format errors #114