Skip to content

Conversation

@kannon92
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Enable MaxLength.

Which issue(s) this PR fixes:

Partially address #7119

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 15, 2025
@netlify
Copy link

netlify bot commented Oct 15, 2025

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 1dd2a62
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6903ca3370d39f0007ce37ae

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 15, 2025
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM
Thanks 💯

@kannon92 kannon92 force-pushed the add-max-length branch 2 times, most recently from a76da24 to c9b0694 Compare October 17, 2025 20:00
@mimowo
Copy link
Contributor

mimowo commented Oct 23, 2025

I checked the failure: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_kueue/7283/pull-kueue-test-e2e-tas-main/1980645093949837312

from kube-scheduler logs Kueue was running on worker5 and worker2:

2025-10-21T14:51:57.333944232Z stderr F I1021 14:51:57.333743       1 eventhandlers.go:135] "Add event for unscheduled pod" pod="kueue-system/kueue-controller-manager-7b4d4fbd98-qf55b"
2025-10-21T14:51:57.333995463Z stderr F I1021 14:51:57.333824       1 schedule_one.go:100] "Attempting to schedule pod" pod="kueue-system/kueue-controller-manager-7b4d4fbd98-qf55b"
2025-10-21T14:51:57.334512139Z stderr F I1021 14:51:57.334342       1 pod_binding.go:51] "Attempting to bind pod to node" pod="kueue-system/kueue-controller-manager-7b4d4fbd98-qf55b" node="kind-worker5"
2025-10-21T14:51:57.357222564Z stderr F I1021 14:51:57.353597       1 eventhandlers.go:219] "Delete event for unscheduled pod" pod="kueue-system/kueue-controller-manager-7b4d4fbd98-qf55b"
2025-10-21T14:51:57.357249724Z stderr F I1021 14:51:57.353988       1 eventhandlers.go:135] "Add event for unscheduled pod" pod="kueue-system/kueue-controller-manager-7b4d4fbd98-tkrgt"
2025-10-21T14:51:57.357254524Z stderr F I1021 14:51:57.354227       1 schedule_one.go:100] "Attempting to schedule pod" pod="kueue-system/kueue-controller-manager-7b4d4fbd98-tkrgt"
2025-10-21T14:51:57.357258974Z stderr F I1021 14:51:57.353866       1 eventhandlers.go:260] "Add event for scheduled pod" pod="kueue-system/kueue-controller-manager-7b4d4fbd98-qf55b"
2025-10-21T14:51:57.357263885Z stderr F I1021 14:51:57.355430       1 schedule_one.go:346] "Successfully bound pod to node" pod="kueue-system/kueue-controller-manager-7b4d4fbd98-qf55b" node="kind-worker5" evaluatedNodes=9 feasibleNodes=8
2025-10-21T14:51:57.357268545Z stderr F I1021 14:51:57.356225       1 pod_binding.go:51] "Attempting to bind pod to node" pod="kueue-system/kueue-controller-manager-7b4d4fbd98-tkrgt" node="kind-worker2"
2025-10-21T14:51:57.373929258Z stderr F I1021 14:51:57.373538       1 schedule_one.go:346] "Successfully bound pod to node" pod="kueue-system/kueue-controller-manager-7b4d4fbd98-tkrgt" node="kind-worker2" evaluatedNodes=9 feasibleNodes=8
2025-10-21T14:51:57.374614186Z stderr F I1021 14:51:57.374457       1 eventhandlers.go:260] "Add event for scheduled pod" pod="kueue-system/kueue-controller-manager-7b4d4fbd98-tkrgt"
2025-10-21T14:51:57.375884501Z stderr F I1021 14:51:57.375654       1 eventhandlers.go:219] "Delete event for unscheduled pod" pod="kueue-system/kueue-controller-manager-7b4d4fbd98-tkrgt"

then I checked the logs on kind-worker2:

https://storage.googleapis.com/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_kueue/7283/pull-kueue-test-e2e-tas-main/1980645093949837312/artifacts/run-test-tas-e2e-1.34.0/kind-worker2/pods/kueue-system_kueue-controller-manager-7b4d4fbd98-tkrgt_c39a2d18-e4cb-4a03-8e90-516c72ec0d03/manager/0.log

show panic:

2025-10-21T14:51:58.593313591Z stderr F 2025-10-21T14:51:58.587721326Z	LEVEL(-2)	setup	features/kube_features.go:340	Loaded feature gates	{"featureGates": {"AdmissionFairSharing":false,"ConfigurableResourceTransformations":true,"DynamicResourceAllocation":false,"ElasticJobsViaWorkloadSlices":false,"ExposeFlavorsInLocalQueue":true,"FlavorFungibility":true,"FlavorFungibilityImplicitPreferenceDefault":false,"HierarchicalCohorts":true,"LendingLimit":true,"LocalQueueDefaulting":true,"LocalQueueMetrics":true,"ManagedJobsNamespaceSelector":true,"ManagedJobsNamespaceSelectorAlwaysRespected":false,"MultiKueue":true,"MultiKueueAdaptersForCustomJobs":false,"MultiKueueBatchJobWithManagedBy":true,"ObjectRetentionPolicies":true,"PartialAdmission":true,"PrioritySortingWithinCohort":true,"ProvisioningACC":true,"TASFailedNodeReplacement":true,"TASFailedNodeReplacementFailFast":true,"TASProfileLeastFreeCapacity":false,"TASProfileMixed":false,"TASReplaceNodeOnPodTermination":true,"TopologyAwareScheduling":true,"VisibilityOnDemand":true,"WorkloadRequestUseMergePatch":false}}
2025-10-21T14:51:58.593318891Z stderr F 2025-10-21T14:51:58.588173271Z	LEVEL(-2)	setup	kueue/main.go:201	K8S Client	{"qps": 50, "burst": 100}
2025-10-21T14:51:58.611552515Z stderr F 2025-10-21T14:51:58.611287501Z	ERROR	setup	kueue/main.go:247	Unable to setup indexes	{"error": "setting index on queue for Workload: no matches for kind \"Workload\" in version \"kueue.x-k8s.io/v1beta1\""}
2025-10-21T14:51:58.611585825Z stderr F main.main
2025-10-21T14:51:58.611591605Z stderr F 	/workspace/cmd/kueue/main.go:247
2025-10-21T14:51:58.611596035Z stderr F runtime.main
2025-10-21T14:51:58.611600165Z stderr F 	/usr/local/go/src/runtime/proc.go:285

@kannon92
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 29, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 29, 2025
@kannon92 kannon92 requested a review from mimowo October 29, 2025 20:18
@kannon92
Copy link
Contributor Author

@mimowo @tenzen-y this is ready for a review again.

//
// +required
// +listType=atomic
// +kubebuilder:validation:MaxItems=64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// +kubebuilder:validation:MaxItems=64
// +kubebuilder:validation:MaxItems=100000

This number can be large, this is the number of nodes essentially

// clusterQueuePendingWorkload contains the list of top pending workloads.
// +listType=atomic
// +optional
// +kubebuilder:validation:MaxItems=64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type is going to be removed anyway, so maybe just mark it no lint?

Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another pass, I think when these are applied I'm happy to merge the PR.

cc @tenzen-y if you could also give it another pass

@kannon92 kannon92 force-pushed the add-max-length branch 2 times, most recently from eb195a2 to 54d209a Compare October 30, 2025 20:08
@mimowo
Copy link
Contributor

mimowo commented Oct 31, 2025

/lgtm
/approve
I double checked and lgtm, we still have time before the release to address some issues if any found.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6f8a482c0827cdf2c6b6b81483398bca7e3c1686

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2025
@k8s-ci-robot k8s-ci-robot merged commit 8b2669e into kubernetes-sigs:main Oct 31, 2025
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.15 milestone Oct 31, 2025
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.
@kannon92 Thank you!
/approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants