Full tentative v1 API review

[mimowo]

What type of PR is this?

/kind api-change

What this PR does / why we need it:

To allow reviewing the tentative full v1 API without exploding the diff by changes in the code.

Which issue(s) this PR fixes:

Related to #7113

Special notes for your reviewer:

The purpose of the PR is to allow review of the entire Kueue API for the API reviewers with the tentative goal of having good v1.

Our mid term goal is to have a good v1beta2 which will be as close to v1 as possible.

However, some of the proposals (more involving) might be deferred from v1beta2 for later before full v1.

This is how I prepared the PR:

1. copy-pasted the v1beta1 API and adjusted the package names etc
2. dropped the "init()" functions so that it doesn't error in vs-code
3. applied adjustments proposed in the doc
4. copied the constants under pkg/controller/constants/constants.go into apis/kueue/v1beta2/constants.go as they are de-facto part of the API by defining names of important labels and annotations.

Does this PR introduce a user-facing change?

NONE

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	3f9f99a
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/68fa32da5c16f10008acbc51

[mimowo]

cc @tenzen-y @gabesaba @mwysokin @kannon92 @mwielgus @dgrove-oss @amy

[mimowo]

/reopen

[k8s-ci-robot]

@mimowo: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mimowo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mimowo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mimowo]

/retest

[kannon92]

config apis are not quite the same as the CRD API.

Is there a strong reason to graduate these in parallel?

I guess if we don't do it now we probably wouldn't get to it..

[mbobrovskyi]

I would propose graduating visibility separately as well.

[mimowo]

The purpose of the PR is to engage API reviewers early for preperation to V1, providing holistic overview of the API we have, which will all need to reach V1 eventually. Hopefully, we can address most of the feedback already in v1beta2.

As for the graduation itself, it is an open question. I know that technically we can graduate them separately, but I think it would be much easier for users to "be ready for graduation in 0.15", rather than to deal with the constant graduation over multiple releases.

[mimowo]

To make the purpose of the PR more clear I have moved the files under v1 already, and retitled the PR, and updated the "Special notes for your reviewer:" section.

[mbobrovskyi]

@mimowo could you please fix verify test?

[mimowo]

@mimowo could you please fix verify test?

yes, the verify now passes with a bit of post processing to revert the auto-generated code.

[mimowo]

rebased and dropped from the diff for now config API, and visibility API so that it is easier to focus on the main CRD changes (following the suggestion from wg-batch meeting)