fix flakly ingressnginx test #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiorLieberman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/L
LiorLieberman
force-pushed
the
fix-flaky-ingressnginx-test
branch
from
818884c to
61849c1
Compare
|
/cc @mlavacca |
levikobi
reviewed
Mar 7, 2024
k8s-ci-robot
added
the
lgtm
xtineskim
pushed a commit
to xtineskim/ingress2gateway
that referenced
this pull request
Apr 23, 2024
* fix flakly ingressnginx test * address feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Ingress-nginx support mergind different ingresses to one HTTPRoute, but since we used a map to store the ingresses, the order is not consistent, causing tests to be flaky
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
/cc @levikobi
FYI @YTGhost