Skip to content

conformance: HTTPRoute resolvedRefs condition always checked #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2023
Merged

conformance: HTTPRoute resolvedRefs condition always checked #1668

merged 1 commit into from
Mar 13, 2023

Conversation

mlavacca
Copy link
Member

@mlavacca mlavacca commented Jan 23, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

In the conformance tests, the ResolvedRefs condition existence is always checked, even when true.

Which issue(s) this PR fixes:

Fixes #1314

Does this PR introduce a user-facing change?:

The conformance tests always check that the HTTPRoute ResolvedRefs condition is enforced, even when the status is true.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 23, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 23, 2023
@mlavacca mlavacca force-pushed the conformance-resolvedrefs-httproute branch 3 times, most recently from 2c5a7d8 to 85d3f59 Compare January 25, 2023 14:38
@mlavacca mlavacca marked this pull request as ready for review January 25, 2023 14:39
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 25, 2023
shaneutt
shaneutt reviewed Jan 25, 2023
View reviewed changes
@mlavacca
Copy link
Member Author

Converting it to draft as it needs some additional work and likely I won't be back to it until next week.

@mlavacca mlavacca marked this pull request as draft February 14, 2023 14:34
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 14, 2023
@shaneutt
Copy link
Member

shaneutt commented Mar 8, 2023

How's it going @mlavacca? Need any help to move this one forward?

@mlavacca
Copy link
Member Author

mlavacca commented Mar 9, 2023

How's it going @mlavacca? Need any help to move this one forward?

I'm sorry for the delay. I didn't manage to work on this one lately. I'll do my best to complete it soon

@shaneutt
Copy link
Member

No worries at all, just let us know if there's anything we can do in support of you 🖖

@mlavacca mlavacca force-pushed the conformance-resolvedrefs-httproute branch from 85d3f59 to 5ef01ae Compare March 10, 2023 16:18
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 10, 2023
@mlavacca
conformance: HTTPRoute resolvedRefs condition
96c0d11 
In the conformance tests, the ResolvedRefs condition existence is
always enforced, even when true.

Signed-off-by: Mattia Lavacca <[email protected]>
@mlavacca mlavacca force-pushed the conformance-resolvedrefs-httproute branch from 55333b4 to 96c0d11 Compare March 10, 2023 16:58
@mlavacca mlavacca marked this pull request as ready for review March 10, 2023 16:58
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2023
@k8s-ci-robot k8s-ci-robot requested a review from mikemorris March 10, 2023 16:58
@mlavacca
Copy link
Member Author

@shaneutt it's ready to be reviewed now. I also addressed your comment from the early review phase

@mlavacca mlavacca requested review from shaneutt and removed request for robscott, howardjohn, bowei and mikemorris March 10, 2023 16:59
shaneutt
shaneutt approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor, looks clean. Looks good to me, but will wait to have at least one other reviewer give it a double check. 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlavacca, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2023
robscott
robscott reviewed Mar 13, 2023
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mlavacca!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5df45bc into kubernetes-sigs:main Mar 13, 2023
@shaneutt shaneutt added this to the v0.6.2 milestone Mar 14, 2023
shaneutt pushed a commit to shaneutt/gateway-api that referenced this pull request Mar 14, 2023
@k8s-ci-robot @shaneutt
Merge pull request kubernetes-sigs#1668 from mlavacca/conformance-res…
c1a1ae8 
…olvedrefs-httproute

conformance: HTTPRoute resolvedRefs condition always checked
@sunjayBhatia sunjayBhatia mentioned this pull request Mar 14, 2023
Merged
arkodg added a commit to arkodg/gateway that referenced this pull request Mar 15, 2023
@arkodg
Always set ResolvedRefs
c7abfdf 
Incorporates check added by kubernetes-sigs/gateway-api#1668

Signed-off-by: Arko Dasgupta <[email protected]>
arkodg added a commit to arkodg/gateway that referenced this pull request Mar 15, 2023
@arkodg
Always set ResolvedRefs
f219076 
Incorporates check added by kubernetes-sigs/gateway-api#1668

Signed-off-by: Arko Dasgupta <[email protected]>
arkodg added a commit to arkodg/gateway that referenced this pull request Mar 17, 2023
@arkodg
Always set ResolvedRefs
c284094 
Incorporates check added by kubernetes-sigs/gateway-api#1668

Signed-off-by: Arko Dasgupta <[email protected]>
arkodg added a commit to arkodg/gateway that referenced this pull request Mar 17, 2023
@arkodg
Always set ResolvedRefs
8bd59d2 
Incorporates check added by kubernetes-sigs/gateway-api#1668

Signed-off-by: Arko Dasgupta <[email protected]>
arkodg added a commit to arkodg/gateway that referenced this pull request Mar 21, 2023
@arkodg
Always set ResolvedRefs
e45583b 
Incorporates check added by kubernetes-sigs/gateway-api#1668

Signed-off-by: Arko Dasgupta <[email protected]>
arkodg added a commit to arkodg/gateway that referenced this pull request Mar 21, 2023
@arkodg
Always set ResolvedRefs
bfc3be1 
Incorporates check added by kubernetes-sigs/gateway-api#1668

Signed-off-by: Arko Dasgupta <[email protected]>
arkodg added a commit to arkodg/gateway that referenced this pull request Mar 21, 2023
@arkodg
Always set ResolvedRefs
32f8694 
Incorporates check added by kubernetes-sigs/gateway-api#1668

Signed-off-by: Arko Dasgupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott left review comments

@shaneutt shaneutt shaneutt approved these changes

@youngnick youngnick Awaiting requested review from youngnick

@sunjayBhatia sunjayBhatia Awaiting requested review from sunjayBhatia

@skriss skriss Awaiting requested review from skriss

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
No open projects
Gateway API: The Road to GA
Status: Done
Milestone
v0.6.2
Development

Successfully merging this pull request may close these issues.

conformance: always check resolvedRefs condition in HTTPRoute conformance tests
4 participants
@mlavacca @k8s-ci-robot @shaneutt @robscott