Skip to content

Conversation

ivankatliarchuk
Copy link
Contributor

What does it do ?

Update release docs and added best practices how to release.

Motivation

Quite often users do update minor versions, with the expectation, that breaking changes are only in major version, that we not yet planning.

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

Signed-off-by: ivan katliarchuk <[email protected]>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign raffo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 7, 2025
@coveralls
Copy link

coveralls commented Oct 7, 2025

Pull Request Test Coverage Report for Build 18427385678

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 78.586%

Totals Coverage Status
Change from base Build 18416862229: 0.005%
Covered Lines: 15846
Relevant Lines: 20164

💛 - Coveralls

Signed-off-by: ivan katliarchuk <[email protected]>
@ivankatliarchuk
Copy link
Contributor Author

/retest

Signed-off-by: ivan katliarchuk <[email protected]>
@@ -0,0 +1,164 @@
# 🧭 External-DNS Version Upgrade Playbook
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

docs/release.md Outdated
External-DNS follows semantic versioning principles:

- `0.x` → pre-stable, APIs subject to change.
- `1.x` → stable APIs and core functionality; breaking changes require a major bump.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather say that we never have v1.0, because I'm Go it means you should never change a public exposed thing (method, func, ... does not matter).
We try to be stable enough for users such that features like source, annotations and providers don't break without migration path or we call it a bug that we want to fix as soon as possible (so fast as our time permits no eta).

Users should check each minor version release notes to the v0.x.0 release page which will explain how to migrate a breaking change without an issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Updated

* master:
  update test certs used for pdns (kubernetes-sigs#5902)
  chore(controller-gen): move tools under go tools (kubernetes-sigs#5878)
  refactor(source/wrappers): move wrappers logic away from execute file (kubernetes-sigs#5888)
  chore(deps): bump the dev-dependencies group with 2 updates (kubernetes-sigs#5895)
  chore(deps): bump renovatebot/github-action (kubernetes-sigs#5890)
Signed-off-by: ivan katliarchuk <[email protected]>
- Use `--dry-run` mode to preview intended changes:
- Validate logs for any unexpected record changes.
- Ensure `external-dns` correctly identifies and plans updates without actually applying them.
- **submit a feature request if `dry-run` is not supported for a specific case
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **submit a feature request if `dry-run` is not supported for a specific case
- **submit a feature request** if `dry-run` is not supported for a specific case

Comment on lines +73 to +75
```sh
aws route53 list-resource-record-sets --hosted-zone-id ZONE_ID > backup.json
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```sh
aws route53 list-resource-record-sets --hosted-zone-id ZONE_ID > backup.json
```
```sh
aws route53 list-resource-record-sets --hosted-zone-id ZONE_ID > backup.json
```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. docs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants