Skip to content

Conversation

@dshatokhin
Copy link
Contributor

@dshatokhin dshatokhin commented Aug 14, 2025

What does it do ?

This PR introduces ability to configure --annotation-filter flag with annotationFilter helm value.

Motivation

Both labelFilter and annotationFilter should be supported and be easily configurable with helm chart.

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

Our team is moving from bitnami chart to this one and this change would be useful for other teams who probably doing the same. This will help us to ensure smooth transition without breaking expectations.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. scripts Issues or PRs related to internal scripts needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 14, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @dshatokhin!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @dshatokhin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 14, 2025
@dshatokhin dshatokhin changed the title Add annotation filter feat(chart): dd annotation filter Aug 14, 2025
@dshatokhin dshatokhin changed the title feat(chart): dd annotation filter feat(chart): add option to configure annotationFilter via dedicated helm value Aug 14, 2025
@stevehipwell
Copy link
Contributor

Thanks for the PR @dshatokhin.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 14, 2025
Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nits.

@dshatokhin
Copy link
Contributor Author

Thanks, @stevehipwell

Also added trailing period to labelFilter comment string because it was actually what I've copied for annotationFilter value

@stevehipwell
Copy link
Contributor

Thanks @dshatokhin, I debated suggesting you also fixed the label filters comment so thanks for reading my mind.

@ivankatliarchuk could you please review and approve as there are changes outside of the chart dir.

/label tide/merge-method-squash
/lgtm

@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 14, 2025
Copy link
Member

@ivankatliarchuk ivankatliarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5578004 into kubernetes-sigs:master Aug 15, 2025
16 checks passed
troll-os pushed a commit to FiligranHQ/external-dns that referenced this pull request Aug 28, 2025
…elm value (kubernetes-sigs#5737)

* chore(scripts): fix `helm schema` flag

Signed-off-by: Denis Shatokhin <[email protected]>

* feat(chart): add option to configure `annotationFilter` via dedicated helm value

Signed-off-by: Denis Shatokhin <[email protected]>

* chore(docs): update changelog with pr

Signed-off-by: Denis Shatokhin <[email protected]>

* chore(chart): add period to the description string

Signed-off-by: Denis Shatokhin <[email protected]>

* chore(docs): update changelog list of changes

Signed-off-by: Denis Shatokhin <[email protected]>

---------

Signed-off-by: Denis Shatokhin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. chart cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. scripts Issues or PRs related to internal scripts size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants