-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(chart): add option to configure annotationFilter via dedicated helm value #5737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart): add option to configure annotationFilter via dedicated helm value #5737
Conversation
Signed-off-by: Denis Shatokhin <[email protected]>
… helm value Signed-off-by: Denis Shatokhin <[email protected]>
|
Welcome @dshatokhin! |
|
Hi @dshatokhin. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Denis Shatokhin <[email protected]>
|
Thanks for the PR @dshatokhin. /ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of nits.
Signed-off-by: Denis Shatokhin <[email protected]>
Signed-off-by: Denis Shatokhin <[email protected]>
|
Thanks, @stevehipwell Also added trailing period to |
|
Thanks @dshatokhin, I debated suggesting you also fixed the label filters comment so thanks for reading my mind. @ivankatliarchuk could you please review and approve as there are changes outside of the chart dir. /label tide/merge-method-squash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivankatliarchuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…elm value (kubernetes-sigs#5737) * chore(scripts): fix `helm schema` flag Signed-off-by: Denis Shatokhin <[email protected]> * feat(chart): add option to configure `annotationFilter` via dedicated helm value Signed-off-by: Denis Shatokhin <[email protected]> * chore(docs): update changelog with pr Signed-off-by: Denis Shatokhin <[email protected]> * chore(chart): add period to the description string Signed-off-by: Denis Shatokhin <[email protected]> * chore(docs): update changelog list of changes Signed-off-by: Denis Shatokhin <[email protected]> --------- Signed-off-by: Denis Shatokhin <[email protected]>
What does it do ?
This PR introduces ability to configure
--annotation-filterflag withannotationFilterhelm value.Motivation
Both
labelFilterandannotationFiltershould be supported and be easily configurable with helm chart.More
Our team is moving from bitnami chart to this one and this change would be useful for other teams who probably doing the same. This will help us to ensure smooth transition without breaking expectations.