-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
Description
Go 1.13 is out 🎉 !
Things we can now do:
- Banish Gopkg.toml into the shadow realm (⚠️ Remove dep usage and Gopkg.* #598)
- Clean up the various scripts referencing Gopkg.toml (⚠️ Remove dep usage and Gopkg.* #598)
Things we can do now-ish
For everything below, we'll need to figure out a potential impact of aggressively switching to Go 1.13 as the min-supported-go-version. I expect Kubernetes will soon-ish, so it might not be that bad for us to do so now. That being said, it's almost certainly a breaking change.
- switch go.mod over to go1.13, so we can use new features
- Prune any uses of xerrors
- Figure out where we want to use
%w
instead of%v
inErrorf
- Figure out if there are spots where we wanted to use wrapping errors but couldn't, and come up with a plan for switching over (relatedly, provide transition plans for folks using
apierrors.IsXYZ
) -- will be a⚠️ breaking change - revive the structured errors code/figure out what we want to do with that
- figure out if we want to prune uses of
GO111MODULE=on
from our scripts?
rajathagasthya, boddumanohar and hzliangbin
Metadata
Metadata
Assignees
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.