Skip to content

[release-1.9] 🌱 Cache DiscoveryVariables calls #11599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Dec 20, 2024
Merged

[release-1.9] 🌱 Cache DiscoveryVariables calls #11599

k8s-ci-robot merged 1 commit into from
Dec 20, 2024

Conversation

@k8s-infra-cherrypick-robot
Copy link

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot commented Dec 19, 2024

This is an automated cherry-pick of #11592

/assign sbueringer

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Dec 19, 2024
Merged
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Dec 19, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 19, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 19, 2024
@chrischdi
Copy link
Member

chrischdi commented Dec 20, 2024

/area runtime-sdk

@k8s-ci-robot k8s-ci-robot added area/runtime-sdk Issues or PRs related to Runtime SDK and removed do-not-merge/needs-area PR is missing an area label labels Dec 20, 2024
@chrischdi
Copy link
Member

chrischdi commented Dec 20, 2024

/test pull-cluster-api-e2e-main

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 20, 2024

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-release-1-9
  • /test pull-cluster-api-e2e-blocking-release-1-9
  • /test pull-cluster-api-e2e-conformance-ci-latest-release-1-9
  • /test pull-cluster-api-e2e-conformance-release-1-9
  • /test pull-cluster-api-e2e-mink8s-release-1-9
  • /test pull-cluster-api-e2e-release-1-9
  • /test pull-cluster-api-e2e-upgrade-1-31-1-32-release-1-9
  • /test pull-cluster-api-test-mink8s-release-1-9
  • /test pull-cluster-api-test-release-1-9
  • /test pull-cluster-api-verify-release-1-9

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-release-1-9

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-release-1-9
  • pull-cluster-api-build-release-1-9
  • pull-cluster-api-e2e-blocking-release-1-9
  • pull-cluster-api-test-release-1-9
  • pull-cluster-api-verify-release-1-9
Details

In response to this:

/test pull-cluster-api-e2e-main

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 20, 2024

LGTM label has been added.

DetailsGit tree hash: e6b4b961e944ad496a21d3b3b1767b23b1499211

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6c909a0 into kubernetes-sigs:release-1.9 Dec 20, 2024
21 checks passed
@chrischdi
Copy link
Member

chrischdi commented Dec 20, 2024

damnit, wanted to trigger a different test :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrischdi chrischdi Awaiting requested review from chrischdi

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.9

Development

Successfully merging this pull request may close these issues.

5 participants

@k8s-infra-cherrypick-robot @chrischdi @k8s-ci-robot @sbueringer @fabriziopandini