Skip to content

✨ Upgrade CAPI to v0.4.0-beta.0 #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jun 9, 2021

What this PR does / why we need it:
Update to current CAPI version before our own beta.0 release. Also went through the CAPI v1alpha3=>v1alpha4 migration doc again (https://github.com/kubernetes-sigs/cluster-api/blob/master/docs/book/src/developer/providers/v1alpha3-to-v1alpha4.md).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Partially implements: #796

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 9, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 9, 2021
@chrischdi
Copy link
Member

Looks like there's a different binary used in make generate.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2021
@sbueringer sbueringer force-pushed the pr-upgrade-capi-to-v0.4.0-beta.0 branch from 5390ab5 to 6f40b0d Compare June 9, 2021 05:21
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 9, 2021
@sbueringer
Copy link
Member Author

Looks like there's a different binary used in make generate.

/lgtm

Thx, fixed, ptal :)

@sbueringer sbueringer force-pushed the pr-upgrade-capi-to-v0.4.0-beta.0 branch from 6f40b0d to 403606c Compare June 9, 2021 06:41
@sbueringer
Copy link
Member Author

Had to fix the cluster templates. There is a breaking change in KubeadmControlPlane (just another reason why v1alpha3 is not really compatible with v1alpha4, which is intended)

@jichenjc
Copy link
Contributor

jichenjc commented Jun 9, 2021

generally looks good
let's wait for e2e test

@sbueringer sbueringer force-pushed the pr-upgrade-capi-to-v0.4.0-beta.0 branch from 403606c to d428660 Compare June 9, 2021 07:52
@sbueringer
Copy link
Member Author

sbueringer commented Jun 9, 2021

@hidekazuna thx, ptal :)
@jichenjc last findings fixed. tests have been green once. I would like to merge relatively soon after the tests are green again after the last fixes.

@sbueringer sbueringer force-pushed the pr-upgrade-capi-to-v0.4.0-beta.0 branch from d428660 to 8dd0d75 Compare June 9, 2021 08:07
@hidekazuna
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2021
@jichenjc
Copy link
Contributor

jichenjc commented Jun 9, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jichenjc,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit 93cba95 into kubernetes-sigs:master Jun 9, 2021
@sbueringer sbueringer deleted the pr-upgrade-capi-to-v0.4.0-beta.0 branch June 9, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants