-
Notifications
You must be signed in to change notification settings - Fork 278
✨ Upgrade CAPI to v0.4.0-beta.0 #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Upgrade CAPI to v0.4.0-beta.0 #901
Conversation
Looks like there's a different binary used in /lgtm |
5390ab5
to
6f40b0d
Compare
Thx, fixed, ptal :) |
6f40b0d
to
403606c
Compare
Had to fix the cluster templates. There is a breaking change in KubeadmControlPlane (just another reason why v1alpha3 is not really compatible with v1alpha4, which is intended) |
generally looks good |
403606c
to
d428660
Compare
@hidekazuna thx, ptal :) |
d428660
to
8dd0d75
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What this PR does / why we need it:
Update to current CAPI version before our own beta.0 release. Also went through the CAPI v1alpha3=>v1alpha4 migration doc again (https://github.com/kubernetes-sigs/cluster-api/blob/master/docs/book/src/developer/providers/v1alpha3-to-v1alpha4.md).
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Partially implements: #796
Special notes for your reviewer:
TODOs:
/hold