Skip to content

🏃 Refactor/cleanup load balancer related code #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2021
Merged

🏃 Refactor/cleanup load balancer related code #835

merged 1 commit into from
Apr 7, 2021

Conversation

seanschneeweiss
Copy link
Contributor

What this PR does / why we need it:
Overall this PR only refactors code to clean up some parts.

  • This PR fixes the notation for load balancer related logs. The split notation load balancer is used.
  • Also this PR restructures the GetOrCreateFloatingIP function for easier readability and removes a possible nil reference in the log line.
  • This PR also renames some variables that shadowed imported package names.

TODOs:

  • squashed commits

/hold
Sean Schneeweiss [email protected], Daimler TSS GmbH, legal info/Impressum

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 6, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @seanschneeweiss. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 6, 2021
@sbueringer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 6, 2021
@seanschneeweiss seanschneeweiss force-pushed the restructure-getcreate-floatingip branch 2 times, most recently from 65ce348 to 06364a8 Compare April 6, 2021 16:25
sbueringer
sbueringer reviewed Apr 6, 2021
View reviewed changes
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2021
@seanschneeweiss seanschneeweiss force-pushed the restructure-getcreate-floatingip branch from 06364a8 to 4df222e Compare April 6, 2021 16:29
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2021
@sbueringer
Copy link
Member

/lgtm
@seanschneeweiss just good timing as usual :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2021
hidekazuna
hidekazuna suggested changes Apr 7, 2021
View reviewed changes
pkg/cloud/services/networking/floatingip.go Outdated
}

record.Eventf(openStackCluster, "SuccessfulCreateFloatingIP", "Created floating IP %s with id %s", ip, fp.ID)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ip argument is optional, so ip must be fp.FloatingIP here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I've changed it accordingly.

@seanschneeweiss
restructure GetOrCreateFloatingIP, unify notation
7a8e37d 
Unify notation of load balancer, rename variables that cover pkg name.
Update mover.md toc.

Signed-off-by: Sean Schneeweiss <[email protected]>
@seanschneeweiss seanschneeweiss force-pushed the restructure-getcreate-floatingip branch from 4df222e to 7a8e37d Compare April 7, 2021 08:28
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2021
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2021
@hidekazuna
Copy link
Contributor

/approve

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hidekazuna, seanschneeweiss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit d631a3f into kubernetes-sigs:master Apr 7, 2021
This was referenced May 18, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jichenjc jichenjc Awaiting requested review from jichenjc

2 more reviewers

@sbueringer sbueringer sbueringer left review comments

@hidekazuna hidekazuna hidekazuna requested changes

Reviewers whose approvals may not affect merge requirements
Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seanschneeweiss @k8s-ci-robot @sbueringer @hidekazuna