Skip to content

Fix gate issue (test failure) #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2021
Merged

Fix gate issue (test failure) #767

merged 1 commit into from
Mar 5, 2021

Conversation

jichenjc
Copy link
Contributor

@jichenjc jichenjc commented Mar 4, 2021

What this PR does / why we need it:

gate test is failing ...

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 4, 2021
@jichenjc jichenjc mentioned this pull request Mar 4, 2021
Merged
@sbueringer
Copy link
Member

sbueringer commented Mar 4, 2021 •
edited
Loading

Probably the same here? #768

@prankul88 @jichenjc As we decided to wait for the v1alpha4 PR to merge with any further merges, does it make sense to upgrade to a new v0.3.* version? I'll upgrade to a completely different and newer version. I think this PR probably only makes sense against our release-0.3 branch.

@prankul88 for reference: https://kubernetes.slack.com/archives/CFKJB65G9/p1614314327008700

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 4, 2021

Build failed.

@jichenjc
Copy link
Contributor Author

jichenjc commented Mar 5, 2021

@sbueringer currently gate has issue (test failure)
so I want to fix it and I think it's not related to v1alpha4? just some go mod clean up...

@jichenjc
Copy link
Contributor Author

jichenjc commented Mar 5, 2021

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 5, 2021

Build failed.

@sbueringer
Copy link
Member

@sbueringer currently gate has issue (test failure)
so I want to fix it and I think it's not related to v1alpha4? just some go mod clean up...

Ah okay, so it's mostly about getting OpenLab on other PRs working again?

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2021
@jichenjc
Copy link
Contributor Author

jichenjc commented Mar 5, 2021

recheck

@jichenjc
Copy link
Contributor Author

jichenjc commented Mar 5, 2021

@sbueringer currently gate has issue (test failure)
so I want to fix it and I think it's not related to v1alpha4? just some go mod clean up...

Ah okay, so it's mostly about getting OpenLab on other PRs working again?

/lgtm

yes, that's the purpose..

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 5, 2021

Build succeeded.

@jichenjc
Copy link
Contributor Author

jichenjc commented Mar 5, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit c8c5aae into kubernetes-sigs:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrigl chrigl Awaiting requested review from chrigl

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jichenjc @k8s-ci-robot @sbueringer