Skip to content

🐛Remove start.sh and restart.sh #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2021
Merged

🐛Remove start.sh and restart.sh #761

merged 1 commit into from
Mar 8, 2021

Conversation

jichenjc
Copy link
Contributor

@jichenjc jichenjc commented Mar 2, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #760

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 2, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 2, 2021

Build succeeded.

sbueringer
sbueringer suggested changes Mar 2, 2021
View reviewed changes
Dockerfile
@@ -30,10 +30,6 @@ RUN go mod download
# Copy the sources
COPY ./ ./

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups deleted my own comment :/

We need this for development: https://cluster-api.sigs.k8s.io/developer/tilt.html
Tilt uses it to live-reload the binary when rebuilding.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah maybe it's not necessary anymore because it's added by tilt. I have to test it:
https://github.com/kubernetes-sigs/cluster-api/blob/master/Tiltfile#L127-L142

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay tested it. Seems like with v1alpha4 they solved this by using a separate dockerfile generated in the Tiltfile.

So while this is a breaking change for development with Tilt on master. It's fine for me as it won't be necessary after we hopefully merged the v1alpha4 PR soon. I also synced the Dockerfile with the upstream cluster-api Dockerfile on the v1alpha4 PR. There seem to be a lot more performance improvements there.: 2fc696d

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I don't know it's from Tilt :)

thanks and it brings trouble to me (can't download those files and have to manually update dockerfile when build image)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jichenjc,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer
Copy link
Member

@jichenjc In my opinion you can merge it if you want (doesnt' conflict with my PR, in fact mine also does it)

@jichenjc
Copy link
Contributor Author

jichenjc commented Mar 8, 2021

@sbueringer please lgtm to this PR ..

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2021
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 53ff1e5 into kubernetes-sigs:master Mar 8, 2021
@jichenjc jichenjc mentioned this pull request Jul 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrigl chrigl Awaiting requested review from chrigl

@hidekazuna hidekazuna Awaiting requested review from hidekazuna

1 more reviewer

@sbueringer sbueringer sbueringer approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make image stuck time to time when download start.sh and restart.sh
3 participants
@jichenjc @k8s-ci-robot @sbueringer