Skip to content

Fix LoadBalancerMember creation #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Fix LoadBalancerMember creation #737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions pkg/cloud/services/loadbalancer/loadbalancer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,6 @@ func (s *Service) ReconcileLoadBalancerMember(clusterName string, machine *clust
s.logger.Info("Reconciling loadbalancer", "name", loadBalancerName)

lbID := openStackCluster.Status.Network.APIServerLoadBalancer.ID
subnetID := openStackCluster.Status.Network.Subnet.ID
portList := []int{int(openStackCluster.Spec.ControlPlaneEndpoint.Port)}
portList = append(portList, openStackCluster.Spec.APIServerLoadBalancerAdditionalPorts...)
for _, port := range portList {
Expand Down Expand Up @@ -268,7 +267,6 @@ func (s *Service) ReconcileLoadBalancerMember(clusterName string, machine *clust
Name: name,
ProtocolPort: port,
Address: ip,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So just that I get it right. Instead of setting the correct subnet (which is invisible to Octavia) we don't set it but Octavia then chooses to subnet automatically? (and I guess it chooses the one we would set)

(fyi, OpenStack cloud controller manager also sets the subnet id, but only if it's configured in the cloud.conf)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. If you omit the subnet_id parameter, the vip_subnet_id for the parent load balancer will be used for the member subnet UUID.
https://docs.openstack.org/api-ref/load-balancer/v2/?expanded=create-member-detail#create-member

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thx for the info

SubnetID: subnetID,
}

if err := waitForLoadBalancerActive(s.logger, s.loadbalancerClient, lbID); err != nil {
Expand Down