📖 Add instructions to use cluster template with load-balancer #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
hidekazuna
suggested changes
Dec 7, 2020
|
Build failed.
|
prankul88
force-pushed
the
conf-update
branch
from
427cfd7 to
b994173
Compare
|
@hidekazuna Hi, PTAL. Would be happy to update if anything else is required. |
|
Build failed.
|
|
recheck |
|
Build succeeded.
|
hidekazuna
reviewed
Dec 25, 2020
…nal-cloud-provider
prankul88
force-pushed
the
conf-update
branch
from
b994173 to
593b49c
Compare
|
@hidekazuna @jichenjc PTAL. Have updated upon the comments. Please let me know if any other changes are required. Thanks |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Build succeeded.
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc, prankul88 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently the capi quick-start only refers to generating config for default template. This PR adds instructions on how to use
without-lbcluster-template.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: