move from 0.3.1 to 0.3.3 in the CI test #686

jichenjc · 2020-11-23T02:57:06Z

What this PR does / why we need it:

the v0.3.1 is confusing ,we should update to latest version

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

k8s-ci-robot · 2020-11-23T02:57:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jichenjc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

theopenlab-ci · 2020-11-23T03:29:31Z

Build failed.

cluster-api-provider-openstack-current-acceptance-test-v1.18 : FAILURE in 31m 57s

sbueringer · 2020-11-23T09:11:46Z

Makefile

@@ -316,16 +316,16 @@ create-cluster: $(KUSTOMIZE) $(ENVSUBST) ## Create a development Kubernetes clus
 	mkdir ~/.cluster-api
 	chmod +x $(CLUSTERCTL)
 	# Create clusterctl.yaml to use local OpenStack provider
-	mkdir -p ./out/infrastructure-openstack/v0.3.1
+	mkdir -p ./out/infrastructure-openstack/pr


what does pr stand for? I think the reason I added it might have been because clusterctl expected it in this folder. But not sure

yes, my test showed that ,but I think v0.3.1 does not make sense now... at least need move to 0.3.2 or 0.3.3
checking the reason and dependency you mentioned above now..

Yup. Let's see what we need here :). I don't really know anymore where the dependency came from if there is one

FYI: CAPA uses next minor version: v0.7.0
https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/master/clusterctl-settings.json#L5

Error: failed to get provider components for the "openstack" provider: failed to get repository client for the InfrastructureProvider with name openstack: error creating the local filesystem repository client: invalid version: "pr". Version must obey the syntax and semantics of the "Semantic Versioning" specification (http://semver.org/) and path format {basepath}/{provider-name}/{version}/{components.yaml}

this is the issue you mentioned @sbueringer
so we need switch to 0.3.3 and update it whenever we have a new version ...

theopenlab-ci · 2020-12-10T02:22:54Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

theopenlab-ci · 2020-12-10T03:04:57Z

Build failed.

cluster-api-provider-openstack-current-acceptance-test-v1.18 : FAILURE in 40m 00s

jichenjc · 2020-12-10T03:12:21Z

recheck

theopenlab-ci · 2020-12-10T04:58:43Z

Build failed.

cluster-api-provider-openstack-current-acceptance-test-v1.18 : FAILURE in 1h 45m 52s

jichenjc · 2020-12-10T06:05:10Z

recheck

theopenlab-ci · 2020-12-10T07:52:01Z

Build failed.

cluster-api-provider-openstack-current-acceptance-test-v1.18 : FAILURE in 1h 46m 23s

jichenjc · 2020-12-10T08:14:06Z

recheck

theopenlab-ci · 2020-12-10T09:11:19Z

Build succeeded.

cluster-api-provider-openstack-current-acceptance-test-v1.18 : SUCCESS in 56m 40s

jichenjc · 2020-12-14T01:37:26Z

@hidekazuna can you help to check this? Thanks

hidekazuna · 2020-12-14T08:30:46Z

Every time we release patch version, we will update this file. How about using 0.4.0 to avoid update so often?

jichenjc · 2020-12-14T08:34:14Z

Every time we release patch version, we will update this file. How about using 0.4.0 to avoid update so often?

clusterctl need this version as previous comments mentioned, clusterctl will create from desired version (0.3.1 , 0.3.3 etc)
0.4.0 is not ready yet..

hidekazuna · 2020-12-14T08:39:02Z

Every time we release patch version, we will update this file. How about using 0.4.0 to avoid update so often?

clusterctl need this version as previous comments mentioned, clusterctl will create from desired version (0.3.1 , 0.3.3 etc)
0.4.0 is not ready yet..

0.4.0 is semver. master branch is for future version, so that it is not odd to be 0.4.0. Actually CAPA uses future version.

jichenjc · 2020-12-14T08:48:54Z

no , 0.4.0 will not work , because clusterctl will load from docker registry and 0.4.0 not exist now

hidekazuna · 2020-12-14T09:23:54Z

Still I do not understand. CAPO image in CI is tagged with another tag, which is not v0.3.3.
We uses local CAPO for create-cluster target in Makefile.

In my local environment,

echo "  minor: 3" >> ./out/infrastructure-openstack/$(CAPO_VERSION)/metadata.yaml

must be

echo "  minor: 4" >> ./out/infrastructure-openstack/$(CAPO_VERSION)/metadata.yaml

jichenjc · 2020-12-14T09:32:32Z

Error: failed to get provider components for the "openstack" provider: failed to get repository client for the InfrastructureProvider with name openstack: error creating the local filesystem repository client: invalid version: "pr". Version must obey the syntax and semantics of the "Semantic Versioning" specification (http://semver.org/) and path format {basepath}/{provider-name}/{version}/{components.yaml}

and please check our CI

https://logs.openlabtesting.org/logs/86/686/6cbe2fd1b07402d4593376b55f9d48fdef6fdaec/check/cluster-api-provider-openstack-current-acceptance-test-v1.18/dcf3097/job-output.txt.gz

2020-12-10 08:47:40.622041 | ubuntu-bionic-large | Installing Provider="infrastructure-openstack" Version="0.3.3" TargetNamespace="capo-system"

the 0.3.3 is comes from {version} above ..

hidekazuna · 2020-12-15T00:14:27Z

Error: failed to get provider components for the "openstack" provider: failed to get repository client for the InfrastructureProvider with name openstack: error creating the local filesystem repository client: invalid version: "pr". Version must obey the syntax and semantics of the "Semantic Versioning" specification (http://semver.org/) and path format {basepath}/{provider-name}/{version}/{components.yaml}

"pr" is not semver. 0.4.0 is semver. Check out "Semantic Versioning" specification

and please check our CI

https://logs.openlabtesting.org/logs/86/686/6cbe2fd1b07402d4593376b55f9d48fdef6fdaec/check/cluster-api-provider-openstack-current-acceptance-test-v1.18/dcf3097/job-output.txt.gz

2020-12-10 08:47:40.622041 | ubuntu-bionic-large | Installing Provider="infrastructure-openstack" Version="0.3.3" TargetNamespace="capo-system"

the 0.3.3 is comes from {version} above ..

This is because you created 0.3.3 directory.
2020-12-10 08:47:01.732747 | ubuntu-bionic-large | hack/tools/bin/kustomize build config > ./out/infrastructure-openstack/0.3.3/infrastructure-components.yaml

If you create 0.4.0 directory, you will get the following like my local environment.

ubuntu@capi:~/cluster-api-provider-openstack$ clusterctl init --infrastructure openstack --core cluster-api:v${CAPI_VERSION} --bootstrap kubeadm:v${CAPI_VERSION} --control-plane kubeadm:v${CAPI_VERSION}
Fetching providers
Installing cert-manager Version="v0.16.1"
Waiting for cert-manager to be available...
Installing Provider="cluster-api" Version="v0.3.11" TargetNamespace="capi-system"
Installing Provider="bootstrap-kubeadm" Version="v0.3.11" TargetNamespace="capi-kubeadm-bootstrap-system"
Installing Provider="control-plane-kubeadm" Version="v0.3.11" TargetNamespace="capi-kubeadm-control-plane-system"
Installing Provider="infrastructure-openstack" Version="0.4.0" TargetNamespace="capo-system"

hidekazuna · 2020-12-15T00:39:21Z

Trying to save time 😃 #712

jichenjc · 2020-12-15T01:22:27Z

Installing Provider="infrastructure-openstack" Version="0.4.0" TargetNamespace="capo-system"

do we have 0.4 capo in hand?

hidekazuna · 2020-12-16T06:52:05Z

Installing Provider="infrastructure-openstack" Version="0.4.0" TargetNamespace="capo-system"

do we have 0.4 capo in hand?

we load capo docker image into kind cluster:
https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/master/Makefile#L333-L336

jichenjc · 2020-12-16T07:00:34Z

Installing Provider="infrastructure-openstack" Version="0.4.0" TargetNamespace="capo-system"

do we have 0.4 capo in hand?

we load capo docker image into kind cluster:
https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/master/Makefile#L333-L336

understand, so we should keep current 0.3.1 ? at least it looks weird and confusing when debug..

hidekazuna · 2020-12-16T07:08:07Z

0.3.1 is already released. CI is for master, master is to develop 0.4.0. So I like 0.4.0.

jichenjc · 2020-12-16T08:05:59Z

@hidekazuna updated just now ,thanks~

hidekazuna · 2020-12-16T10:27:15Z

Makefile

-	echo "  contract: v1alpha3" >> ./out/infrastructure-openstack/v0.3.1/metadata.yaml
+	echo "releaseSeries:" > ./out/infrastructure-openstack/$(CAPO_VERSION)/metadata.yaml
+	echo "- major: 0" >> ./out/infrastructure-openstack/$(CAPO_VERSION)/metadata.yaml
+	echo "  minor: 3" >> ./out/infrastructure-openstack/$(CAPO_VERSION)/metadata.yaml


we need to update to 4.

sbueringer · 2020-12-16T15:38:06Z

/lgtm

just fyi. cluster-api released 0.3.12 today: https://github.com/kubernetes-sigs/cluster-api/releases/tag/v0.3.12

sbueringer · 2020-12-16T15:38:22Z

/hold

feel free to /hold cancel when you want to merge

jichenjc · 2020-12-17T01:18:25Z

cluster api 0.3.12 is something we might catch up later on (will take a look later on)
so far we can focus on this issue , thanks both of you comments

/hold cancel

jichenjc · 2020-12-17T01:21:34Z

/hold cancel

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 23, 2020

k8s-ci-robot requested review from chrigl and sbueringer November 23, 2020 02:57

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 23, 2020

sbueringer reviewed Nov 23, 2020

View reviewed changes

jichenjc force-pushed the avoid_v31 branch from 1ed3766 to 829f687 Compare December 10, 2020 02:22

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 10, 2020

jichenjc force-pushed the avoid_v31 branch from 829f687 to 6cbe2fd Compare December 10, 2020 02:24

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 10, 2020

jichenjc changed the title ~~move from 0.3.1 to PR in the CI test~~ move from 0.3.1 to 0.3.3 in the CI test Dec 10, 2020

jichenjc force-pushed the avoid_v31 branch from 6cbe2fd to 79fa092 Compare December 16, 2020 08:05

hidekazuna reviewed Dec 16, 2020

View reviewed changes

move from 0.3.1 to 0.4.0(master) in the CI test

4da5f5a

jichenjc force-pushed the avoid_v31 branch from 79fa092 to 4da5f5a Compare December 16, 2020 12:30

k8s-ci-robot assigned sbueringer Dec 16, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2020

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2020

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2020

k8s-ci-robot merged commit 875f3ef into kubernetes-sigs:master Dec 17, 2020

move from 0.3.1 to 0.3.3 in the CI test #686

move from 0.3.1 to 0.3.3 in the CI test #686

Uh oh!

Conversation

jichenjc commented Nov 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Nov 23, 2020

Uh oh!

theopenlab-ci bot commented Nov 23, 2020

Uh oh!

sbueringer Nov 23, 2020

Choose a reason for hiding this comment

Uh oh!

jichenjc Nov 23, 2020

Choose a reason for hiding this comment

Uh oh!

sbueringer Nov 23, 2020

Choose a reason for hiding this comment

Uh oh!

hidekazuna Nov 24, 2020

Choose a reason for hiding this comment

Uh oh!

jichenjc Dec 10, 2020

Choose a reason for hiding this comment

Uh oh!

theopenlab-ci bot commented Dec 10, 2020

Uh oh!

theopenlab-ci bot commented Dec 10, 2020

Uh oh!

jichenjc commented Dec 10, 2020

Uh oh!

theopenlab-ci bot commented Dec 10, 2020

Uh oh!

jichenjc commented Dec 10, 2020

Uh oh!

theopenlab-ci bot commented Dec 10, 2020

Uh oh!

jichenjc commented Dec 10, 2020

Uh oh!

theopenlab-ci bot commented Dec 10, 2020

Uh oh!

jichenjc commented Dec 14, 2020

Uh oh!

hidekazuna commented Dec 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jichenjc commented Dec 14, 2020

Uh oh!

hidekazuna commented Dec 14, 2020

Uh oh!

jichenjc commented Dec 14, 2020

Uh oh!

hidekazuna commented Dec 14, 2020

Uh oh!

jichenjc commented Dec 14, 2020

Uh oh!

hidekazuna commented Dec 15, 2020

Uh oh!

hidekazuna commented Dec 15, 2020

Uh oh!

jichenjc commented Dec 15, 2020

Uh oh!

hidekazuna commented Dec 16, 2020

Uh oh!

jichenjc commented Dec 16, 2020

Uh oh!

hidekazuna commented Dec 16, 2020

Uh oh!

jichenjc commented Dec 16, 2020

Uh oh!

hidekazuna Dec 16, 2020

Choose a reason for hiding this comment

Uh oh!

sbueringer commented Dec 16, 2020

Uh oh!

sbueringer commented Dec 16, 2020

Uh oh!

jichenjc commented Dec 17, 2020

Uh oh!

jichenjc commented Nov 23, 2020 •

edited

Loading

hidekazuna commented Dec 14, 2020 •

edited

Loading