Move log to creating place

[jichenjc]

What this PR does / why we need it:

keep seeing

I1113 00:24:14.043296       1 openstackmachine_controller.go:291] controllers/OpenStackMachine "msg"="Creating Machine" "cluster"="capi-openstack-3" "machine"="capi-openstack-control-plane-d2fnl" "namespace"="default" "openStackCluster"="capi-openstack-3" "openStackMachine"="capi-openstack-control-plane-rthx6"

but actually it's not creating .. it's getOrCreate, so the log is confusing
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jichenjc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[theopenlab-ci]

Build succeeded.

• cluster-api-provider-openstack-current-acceptance-test-v1.18 : SUCCESS in 1h 05m 21s

[hidekazuna]

Not good message is true. I suggest to update to 'Reconciling Machine create started'
in contrast to L370 logger.Info("Reconciled Machine create successfully").

[hidekazuna]

It is best to see event. because SuccessfulCreateServer is just after calling createInstance.
https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/master/pkg/cloud/services/compute/instance.go#L145

[jichenjc]

It is best to see event. because SuccessfulCreateServer is just after calling createInstance.
https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/master/pkg/cloud/services/compute/instance.go#L145

yes, but reading log makes me very confusing .. so better update log

[hidekazuna]

It is best to see event. because SuccessfulCreateServer is just after calling createInstance.
https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/master/pkg/cloud/services/compute/instance.go#L145

yes, but reading log makes me very confusing .. so better update log

Currently create or delete resource start message is not logged. You can refer to network resources creation. We need logging policy.

[theopenlab-ci]

Build failed.

• cluster-api-provider-openstack-current-acceptance-test-v1.18 : FAILURE in 1h 29m 20s

[jichenjc]

It is best to see event. because SuccessfulCreateServer is just after calling createInstance.
https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/master/pkg/cloud/services/compute/instance.go#L145

yes, but reading log makes me very confusing .. so better update log

Currently create or delete resource start message is not logged. You can refer to network resources creation. We need logging policy.

agree

so are you suggesting should I add in this PR for all those logs ?

[hidekazuna]

Currently create or delete resource start message is not logged. You can refer to network resources creation. We need logging policy.

agree

so are you suggesting should I add in this PR for all those logs ?

Raised another issue.

[jichenjc]

recheck

[jichenjc]

@hidekazuna so what about this one? maybe merge first? or anything need change ? thanks

[theopenlab-ci]

Build failed.

• cluster-api-provider-openstack-current-acceptance-test-v1.18 : FAILURE in 1h 28m 56s

[jichenjc]

recheck

[hidekazuna]

/lgtm