Skip to content

✨ Add support for Tilt #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2020
Merged

✨ Add support for Tilt #666

merged 1 commit into from
Nov 13, 2020

Conversation

prankul88
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #649

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 5, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 5, 2020
@prankul88
Copy link
Contributor Author

Will add documentation in CAPI book one this is done.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 5, 2020

Build failed.

@prankul88
Copy link
Contributor Author

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 5, 2020

Build succeeded.

@jichenjc
Copy link
Contributor

jichenjc commented Nov 6, 2020

@prankul88 is this still WIP?

@prankul88
Copy link
Contributor Author

@jichenjc Updating. Just wanted to confirm the behaviour before review. :)

@prankul88 prankul88 changed the title [WIP] ✨ Add support for Tilt ✨ Add support for Tilt Nov 9, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 9, 2020
@prankul88
Copy link
Contributor Author

/assign @jichenjc

@jichenjc
Copy link
Contributor

@prankul88 the changes looks googd,
I am a little bit busy recently so no time to try this locally, I assume you did already?

@hidekazuna please help to merge this , thanks

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, prankul88

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2020
@hidekazuna
Copy link
Contributor

I have never used Tilt, give me some time to try.

@hidekazuna
Copy link
Contributor

@prankul88 I tried. All containers are running, but there are error messages as the followings. Is this expected?

[manager] E1110x12:20:56.6774880     10 reflector.go:153] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:105: Failed to list *v1alpha3.OpenStackCluster: openstackclusters.infrastructure.cluster.x-k8s.io is forbidden: Users
"system:serviceaccount:capo-system:default" cannot list resource "openstackclusters" in API group "infrastructure.cluster.x-k8s.io" at the cluster scope: RBAC: clusterrole.rbac.authorization.k8s.io
"capi-system-capi-aggregated-manager-role" not found
[manager] E1110x12:20:56.6852820     10 reflector.go:153] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:105: Failed to list *v1alpha3.OpenStackMachine: openstackmachines.infrastructure.cluster.x-k8s.io is forbidden: Users
"system:serviceaccount:capo-system:default" cannot list resource "openstackmachines" in API group "infrastructure.cluster.x-k8s.io" at the cluster scope: RBAC: clusterrole.rbac.authorization.k8s.io
"capi-system-capi-aggregated-manager-role" not found

@prankul88
Copy link
Contributor Author

@hidekazuna Not sure if this error is due to tilt.
The containers seemed to work fine.

@jichenjc
Copy link
Contributor

@hidekazuna please lgtm if it's ok to you

@hidekazuna
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit c166776 into kubernetes-sigs:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrigl chrigl Awaiting requested review from chrigl

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@hidekazuna hidekazuna

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Tilt based dev
4 participants
@prankul88 @jichenjc @k8s-ci-robot @hidekazuna