Add openstack ussuri into support list #586

jichenjc · 2020-07-13T08:16:00Z

What this PR does / why we need it:

Add openstack ussuri into support list (tested)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

k8s-ci-robot · 2020-07-13T08:16:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jichenjc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

theopenlab-ci · 2020-07-13T09:48:03Z

Build failed.

cluster-api-provider-openstack-current-acceptance-test-v1.18 : FAILURE in 1h 30m 55s

hidekazuna · 2020-07-13T12:11:48Z

@jichenjc Did you test both HA and non-HA?

jichenjc · 2020-07-13T12:28:30Z

ah... good point, I think you are talking about LB case, correct?
I tested non-LB case today
I can test LB case or have you tested that?

hidekazuna · 2020-07-13T23:22:48Z

@jichenjc

ah... good point, I think you are talking about LB case, correct?

Yes, I am.

I tested non-LB case today
I can test LB case or have you tested that?

Unfortunately I only have stable Stein environment and do not have new machine.

jichenjc · 2020-07-14T01:59:41Z

@jichenjc

ah... good point, I think you are talking about LB case, correct?

Yes, I am.

I tested non-LB case today
I can test LB case or have you tested that?

Unfortunately I only have stable Stein environment and do not have new machine.

ok, I have to create LB env (I only have non-LB env now)

hidekazuna · 2020-07-28T01:17:49Z

@jichenjc Did you test lb version?

jichenjc · 2020-07-28T01:37:07Z

@hidekazuna not yet, run out of my time ,if you can help to verify , then it will be helpful
or I will do it in a few days

hidekazuna · 2020-07-28T01:48:11Z

@hidekazuna not yet, run out of my time ,if you can help to verify , then it will be helpful
or I will do it in a few days

@jichenjc It's OK, I can wait.

jichenjc · 2020-08-17T03:03:20Z

recheck

jichenjc · 2020-08-17T03:20:01Z

@hidekazuna we by default use U release in CI, so I think we can merge this?

theopenlab-ci · 2020-08-17T04:27:54Z

Build failed.

cluster-api-provider-openstack-current-acceptance-test-v1.18 : FAILURE in 1h 24m 01s

jichenjc · 2020-08-17T09:15:54Z

recheck

theopenlab-ci · 2020-08-17T10:38:02Z

Build failed.

cluster-api-provider-openstack-current-acceptance-test-v1.18 : FAILURE in 1h 21m 33s

hidekazuna · 2020-08-17T10:48:40Z

@hidekazuna we by default use U release in CI, so I think we can merge this?

@jichenjc If you tested HA version, we can merge this PR.

fejta-bot · 2020-11-15T10:51:23Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

sbueringer · 2020-11-17T12:05:27Z

@jichenjc any news? Is this PR still active?

jichenjc · 2020-11-17T13:12:28Z

yes, but I am lack of time recently, if you did please help .. thanks @sbueringer

sbueringer · 2020-11-17T13:55:21Z

@jichenjc Sorry I don't have OpenStack Ussuri available, just wanted to ask.
I'm also not entirely sure what exactly we're achieving with our "supported OpenStack versions list".

Almost none of them are continuously tested by us (on every release). So basically it comes down to a handful of versions which we
really know that work, because we're using them all the time. (I assume the actual list is not really in sync with the documented one)

jichenjc · 2020-11-17T23:55:17Z

@sbueringer I agree all you mentioned here, how about let's just say something like
'should work but not tested ...'

theopenlab-ci · 2020-11-18T01:11:44Z

Build succeeded.

cluster-api-provider-openstack-current-acceptance-test-v1.18 : SUCCESS in 54m 42s

sbueringer · 2020-11-18T06:40:17Z

@sbueringer I agree all you mentioned here, how about let's just say something like
'should work but not tested ...'

sounds good to me

hidekazuna · 2020-11-18T06:44:56Z

README.md

+| OpenStack Provider v1alpha2 (v0.2)              | + | ✓ | + | ✓ | + | + | + |
+| OpenStack Provider v1alpha3 (v0.3)              | + | + | + | ✓ | ✓ | ✓ | ✓ |
+
+**NOTE:** : There is no formal CI test for specific OpenStack version, the development team has a CI running on latest OpenStack devstack and that covers most of `✓` at above table.


This is not true. Our OpenStack version in CI is still Ussuri.
https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/master/.zuul/playbooks/run.yaml#L27

CI tests only non HA version. Some OpenStack versions for HA are tested manually.

understand .. thanks for point out
so we need some manual test but actually CI is preferred

let me check how we can do and submit some proposal for review

Ideally using CAPI e2e test framework is the best to test HA. I tried but still in progress. I confirmed it tests HA.

So in this PR, I propose to remove Victoria, and update NOTE:
The development team has a CI using non HA template running on latest OpenStack devstack and that covers most of ✓ at above table. Some versions are tested against HA template.

theopenlab-ci · 2020-11-19T01:31:58Z

Build failed.

cluster-api-provider-openstack-current-acceptance-test-v1.18 : FAILURE in 1h 33m 59s

jichenjc · 2020-11-19T01:37:20Z

recheck

hidekazuna · 2020-11-19T01:47:36Z

@jichenjc We can add Victoria now!!

hidekazuna · 2020-11-19T02:45:34Z

README.md

+| OpenStack Provider v1alpha2 (v0.2)              | + | ✓ | + | ✓ | + | + | + |
+| OpenStack Provider v1alpha3 (v0.3)              | + | + | + | ✓ | ✓ | ✓ | ✓ |
+
+**NOTE:** : The development team has a CI using [non HA template](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/templates/cluster-template-without-lb.yaml) running on latest OpenStack devstack and that covers most of ✓ at above table. Some versions are tested against [HA template](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/templates/cluster-template.yaml).


It is enough to use internal link.

https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/templates/cluster-template-without-lb.yaml
-> ./templates/cluster-template-without-lb.yaml

https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/templates/cluster-template.yaml
-> ./templates/cluster-template.yaml

ok, will do

theopenlab-ci · 2020-11-19T03:07:42Z

Build succeeded.

cluster-api-provider-openstack-current-acceptance-test-v1.18 : SUCCESS in 1h 02m 11s

hidekazuna · 2020-11-19T04:07:08Z

/lgtm

k8s-ci-robot requested review from gyliu513 and sbueringer July 13, 2020 08:16

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 13, 2020

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 15, 2020

jichenjc force-pushed the add_u branch from 9c1d891 to 8cb1dd0 Compare November 18, 2020 00:02

hidekazuna reviewed Nov 18, 2020

View reviewed changes

jichenjc force-pushed the add_u branch from 8cb1dd0 to 24d6fb3 Compare November 18, 2020 23:57

jichenjc force-pushed the add_u branch from 24d6fb3 to 9631cec Compare November 19, 2020 02:05

hidekazuna reviewed Nov 19, 2020

View reviewed changes

Add openstack u/v release into support list

f3c587d

jichenjc force-pushed the add_u branch from 9631cec to f3c587d Compare November 19, 2020 04:05

k8s-ci-robot assigned hidekazuna Nov 19, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2020

k8s-ci-robot merged commit d6a1684 into kubernetes-sigs:master Nov 19, 2020

Add openstack ussuri into support list #586

Add openstack ussuri into support list #586

Uh oh!

Conversation

jichenjc commented Jul 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Jul 13, 2020

Uh oh!

theopenlab-ci bot commented Jul 13, 2020

Uh oh!

hidekazuna commented Jul 13, 2020

Uh oh!

jichenjc commented Jul 13, 2020

Uh oh!

hidekazuna commented Jul 13, 2020

Uh oh!

jichenjc commented Jul 14, 2020

Uh oh!

hidekazuna commented Jul 28, 2020

Uh oh!

jichenjc commented Jul 28, 2020

Uh oh!

hidekazuna commented Jul 28, 2020

Uh oh!

jichenjc commented Aug 17, 2020

Uh oh!

jichenjc commented Aug 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theopenlab-ci bot commented Aug 17, 2020

Uh oh!

jichenjc commented Aug 17, 2020

Uh oh!

theopenlab-ci bot commented Aug 17, 2020

Uh oh!

hidekazuna commented Aug 17, 2020

Uh oh!

fejta-bot commented Nov 15, 2020

Uh oh!

sbueringer commented Nov 17, 2020

Uh oh!

jichenjc commented Nov 17, 2020

Uh oh!

sbueringer commented Nov 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jichenjc commented Nov 17, 2020

Uh oh!

theopenlab-ci bot commented Nov 18, 2020

Uh oh!

sbueringer commented Nov 18, 2020

Uh oh!

hidekazuna Nov 18, 2020

Choose a reason for hiding this comment

Uh oh!

hidekazuna Nov 18, 2020

Choose a reason for hiding this comment

Uh oh!

jichenjc Nov 18, 2020

Choose a reason for hiding this comment

Uh oh!

hidekazuna Nov 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

theopenlab-ci bot commented Nov 19, 2020

Uh oh!

jichenjc commented Nov 19, 2020

Uh oh!

hidekazuna commented Nov 19, 2020

Uh oh!

hidekazuna Nov 19, 2020

Choose a reason for hiding this comment

Uh oh!

jichenjc Nov 19, 2020

Choose a reason for hiding this comment

Uh oh!

theopenlab-ci bot commented Nov 19, 2020

Uh oh!

jichenjc commented Jul 13, 2020 •

edited

Loading

jichenjc commented Aug 17, 2020 •

edited

Loading

sbueringer commented Nov 17, 2020 •

edited

Loading

hidekazuna Nov 18, 2020 •

edited

Loading