Skip to content

Conversation

prankul88
Copy link
Contributor

What this PR does / why we need it:
Updated CAPI to v0.3.5.

Also updated controller-gen tools to v0.2.9

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Update Cluster API to v0.3.5

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 6, 2020
@k8s-ci-robot k8s-ci-robot requested review from gyliu513 and vincepri May 6, 2020 08:09
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 6, 2020
@prankul88
Copy link
Contributor Author

/assign @sbueringer
/assign @jichenjc
/assign @hidekazuna

@jichenjc
Copy link
Contributor

jichenjc commented May 6, 2020

looks good ~, let's see whether CI can pass

@prankul88
Copy link
Contributor Author

Will check again

@prankul88
Copy link
Contributor Author

Forgot to run make modules. Let's see if it works now.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 6, 2020

Build failed.

@sbueringer
Copy link
Member

@prankul88 sorry for the flaky e2e test. Trying to get it fixed here: theopenlab/openlab#504

@prankul88
Copy link
Contributor Author

@prankul88 sorry for the flaky e2e test. Trying to get it fixed here: theopenlab/openlab#504

No problem. Thanks for pointing it out, I was unaware of the ongoing issue.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 11, 2020
@prankul88
Copy link
Contributor Author

@sbueringer PTAL

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 11, 2020

Build failed.

  • cluster-api-provider-openstack-current-acceptance-test-v1.18 : RETRY_LIMIT in 33m 26s

@jichenjc
Copy link
Contributor

code looks good, seems the CI is not related..

@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prankul88, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2020
@sbueringer
Copy link
Member

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 11, 2020

Build failed.

  • cluster-api-provider-openstack-current-acceptance-test-v1.18 : RETRY_LIMIT in 17m 56s

@jichenjc
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit 78939ac into kubernetes-sigs:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants