🐛 enable managedAPIServerLoadBalancer w/ existing network #548

gdetal · 2020-04-21T10:50:19Z

What this PR does / why we need it:

Using managedAPIServerLoadBalancer: true in the OpenStackCluster configuration suggest that a load balancer will be created. However, when specifying an existing Openstack network instead of using nodeCidr, a load balancer is not created.

This PR make sure that:

the load balancer is created;
the controller do not try to remove the existing network.

Which issue(s) this PR fixes *
fixes #547

Special notes for your reviewer:

I had to refactor reconcileNormal as the linter was complaing about a cyclomatic complexity above 30 after my change.

Release note:

k8s-ci-robot · 2020-04-21T10:50:22Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2020-04-21T10:50:27Z

Welcome @gdetal!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2020-04-21T10:50:27Z

Hi @gdetal. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gdetal · 2020-04-21T10:53:13Z

/assign @luxas

theopenlab-ci · 2020-04-21T12:18:59Z

Build failed.

cluster-api-provider-openstack-current-acceptance-test-v1.18 : FAILURE in 1h 27m 47s

jichenjc · 2020-04-22T03:03:49Z

/ok-to-test

gdetal · 2020-04-22T06:41:24Z

/retest

flaper87

Hey folks, I don't work in this project anymore. Would you mind removing me from the reviewers list? Thanks

gdetal · 2020-04-22T08:02:12Z

CLA check

theopenlab-ci · 2020-04-22T09:18:56Z

Build failed.

cluster-api-provider-openstack-current-acceptance-test-v1.18 : FAILURE in 1h 49m 57s

sbueringer · 2020-04-22T18:42:54Z

Hey folks, I don't work in this project anymore. Would you mind removing me from the reviewers list? Thanks

@flaper87 Yup, no problem

sbueringer

just some nits

controllers/openstackcluster_controller.go

sbueringer · 2020-04-22T18:54:47Z

@gdetal just fyi the openlab test has currently an open issue unrelated to your PR, but it's optional for merge (theopenlab/openlab#504)

sbueringer · 2020-04-22T18:55:25Z

/assign

Signed-off-by: Gregory Detal <[email protected]>

theopenlab-ci · 2020-04-23T08:12:29Z

Build failed.

cluster-api-provider-openstack-current-acceptance-test-v1.18 : FAILURE in 2h 17m 20s

sbueringer · 2020-04-23T15:33:22Z

/approve
recheck

Edit: @gdetal looks good to me. Thx for the PR. Now you just have to fix the CLA issue :)

k8s-ci-robot · 2020-04-23T15:33:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gdetal, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sbueringer · 2020-04-23T15:34:26Z

/assign
@jichenjc can you also take a look please?

jichenjc · 2020-04-24T00:50:34Z

/lgtm

gdetal · 2020-04-24T06:12:02Z

Thanks for the review, I still have that CLA issue ongoing... I signed the document but still the bot didn't update the label... @k8s-ci-robot

sbueringer · 2020-04-24T06:16:12Z

/check-cla

sbueringer · 2020-04-24T06:19:42Z

Hm the recheck command should work (https://prow.k8s.io/plugins) Looks like something wrong with either your CLA or the CLA system / bot

gdetal · 2020-04-24T06:21:59Z

@sbueringer that is what I thought, I'll create a ticket on the linuxfoundation support website.

gdetal · 2020-04-24T14:04:10Z

/check-cla

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 21, 2020

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 21, 2020

k8s-ci-robot requested review from flaper87 and justinsb April 21, 2020 10:50

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 21, 2020

k8s-ci-robot assigned luxas Apr 21, 2020

gdetal changed the title ~~🐛 enable managedAPIServerLoadBalancer w/ existing network~~ 🐛 enable managedAPIServerLoadBalancer w/ existing network Apr 21, 2020

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 22, 2020

gdetal force-pushed the fix-managed-lb-existing-network branch from 23642f8 to 269505f Compare April 22, 2020 07:28

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 22, 2020

flaper87 suggested changes Apr 22, 2020

View reviewed changes

sbueringer mentioned this pull request Apr 22, 2020

reviewers: remove flaper87 #549

Merged

sbueringer suggested changes Apr 22, 2020

View reviewed changes

controllers/openstackcluster_controller.go Show resolved Hide resolved

controllers/openstackcluster_controller.go Show resolved Hide resolved

controllers/openstackcluster_controller.go Outdated Show resolved Hide resolved

k8s-ci-robot assigned sbueringer Apr 22, 2020

gdetal added 2 commits April 23, 2020 07:50

refactor reconcileNormal to reduce cyclomatic complexity

2fe8b0b

Signed-off-by: Gregory Detal <[email protected]>

fix: enable managedAPIServerLoadBalancer w/ existing network

7a40347

Signed-off-by: Gregory Detal <[email protected]>

gdetal force-pushed the fix-managed-lb-existing-network branch from 269505f to 7a40347 Compare April 23, 2020 05:54

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 23, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2020

sbueringer approved these changes Apr 23, 2020

View reviewed changes

k8s-ci-robot assigned jichenjc Apr 24, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2020

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 24, 2020

k8s-ci-robot merged commit b62656c into kubernetes-sigs:master Apr 24, 2020

🐛 enable managedAPIServerLoadBalancer w/ existing network #548

🐛 enable managedAPIServerLoadBalancer w/ existing network #548

Uh oh!

Conversation

gdetal commented Apr 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Apr 21, 2020

Uh oh!

k8s-ci-robot commented Apr 21, 2020

Uh oh!

k8s-ci-robot commented Apr 21, 2020

Uh oh!

gdetal commented Apr 21, 2020

Uh oh!

theopenlab-ci bot commented Apr 21, 2020

Uh oh!

jichenjc commented Apr 22, 2020

Uh oh!

gdetal commented Apr 22, 2020

Uh oh!

flaper87 left a comment

Choose a reason for hiding this comment

Uh oh!

gdetal commented Apr 22, 2020

Uh oh!

theopenlab-ci bot commented Apr 22, 2020

Uh oh!

sbueringer commented Apr 22, 2020

Uh oh!

sbueringer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sbueringer commented Apr 22, 2020

Uh oh!

sbueringer commented Apr 22, 2020

Uh oh!

theopenlab-ci bot commented Apr 23, 2020

Uh oh!

sbueringer commented Apr 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Apr 23, 2020

Uh oh!

sbueringer commented Apr 23, 2020

Uh oh!

jichenjc commented Apr 24, 2020

Uh oh!

gdetal commented Apr 24, 2020

Uh oh!

sbueringer commented Apr 24, 2020

Uh oh!

sbueringer commented Apr 24, 2020

Uh oh!

gdetal commented Apr 24, 2020

Uh oh!

gdetal commented Apr 24, 2020

Uh oh!

Uh oh!

gdetal commented Apr 21, 2020 •

edited

Loading

sbueringer commented Apr 23, 2020 •

edited

Loading