-
Notifications
You must be signed in to change notification settings - Fork 278
🌱 Bump e2e k8s versions and update templates #2600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Bump e2e k8s versions and update templates #2600
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
/test pull-cluster-api-provider-openstack-e2e-full-test |
e6dc242
to
fc63dee
Compare
/test pull-cluster-api-provider-openstack-e2e-full-test |
@tormath1 can you help shed some light on this? cluster-api-provider-openstack/kustomize/v1beta1/flatcar-sysext/patch-flatcar.yaml Line 41 in 792395c
❯ curl -L https://github.com/flatcar/sysext-bakery/releases/download/latest/kubernetes-v1.33.conf
Not Found I can also see that the sysext bakery releases are a bit different now. Is it so that we could use something like this instead?
|
Hey @lentzi90 that is correct, with the increasing number of folks using sysext-bakery + the increasing number of sysext images, we enhanced a bit the way we provide system extensions. There is now a documentation page for each sysext (e.g Kubernetes: https://flatcar.github.io/sysext-bakery/kubernetes/) and the "correct" links would now be:
Legacy links was still working for existing system but not for newer releases (e.g Kubernetes 1.33). Sorry for the turbulence here :) |
Awesome, thanks! 🙂 |
fc63dee
to
eee4325
Compare
/test pull-cluster-api-provider-openstack-e2e-full-test |
eee4325
to
3badfda
Compare
/test pull-cluster-api-provider-openstack-e2e-full-test |
3badfda
to
9021477
Compare
Normal tests run with kubernetes v1.33.1. Upgrades are going from v1.32.5 to v1.33.1. Templates needed to be updated for v1.32 as the API server has dropped the cloud-provider flag. Sysext-bakery URLs also updated. Signed-off-by: Lennart Jern <[email protected]>
9021477
to
3f2f020
Compare
/test pull-cluster-api-provider-openstack-e2e-full-test |
Alright I think we are good to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks! Suspect this is worth inclusion in a stable release?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90, mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
That is a good point! I'll try to backport to get the updated templates on the release branches |
@lentzi90: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@lentzi90: #2600 failed to apply on top of branch "release-0.12":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Normal tests run with kubernetes v1.33.1. Upgrades are going from v1.32.5 to v1.33.1.
Templates needed to be updated for v1.32 as the API server has dropped the cloud-provider flag.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
/hold