Skip to content

🌱 Update e2e config and clusterctl-upgrade #2565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

🌱 Update e2e config and clusterctl-upgrade #2565

merged 1 commit into from
May 27, 2025
+83 −49

Conversation

lentzi90
Copy link
Contributor

What this PR does / why we need it:

This updates mostly the clusterctl-upgrade e2e test. We make use of new functionality in the CAPI framework to calculate the latest patch releases instead of hard-coding them. The upgrade start from CAPI v1.9 instead of v1.6, to keep the tested versions within supported releases. Similarly CAPO upgrades from v0.11. Also an upgrade from v0.12 to main is added.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes ##2564

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2025
@netlify Netlify
Copy link

netlify bot commented May 26, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit c20ed8d
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/68359308b122ea00087bd45d
😎 Deploy Preview https://deploy-preview-2565--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 26, 2025
@k8s-ci-robot k8s-ci-robot requested review from EmilienM and mdbooth May 26, 2025 14:06
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 26, 2025
@lentzi90
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test
/test pull-cluster-api-provider-openstack-e2e-test

@lentzi90 lentzi90 force-pushed the lentzi90/e2e-update branch 2 times, most recently from 3948c8c to 52fe7ab Compare May 26, 2025 15:25
@lentzi90
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

1 similar comment
@lentzi90
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@lentzi90 lentzi90 force-pushed the lentzi90/e2e-update branch from 52fe7ab to a6b2732 Compare May 27, 2025 05:07
@lentzi90
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@lentzi90 lentzi90 force-pushed the lentzi90/e2e-update branch from a6b2732 to a008ac9 Compare May 27, 2025 06:17
@lentzi90
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@lentzi90 lentzi90 force-pushed the lentzi90/e2e-update branch from a008ac9 to 6c9f9b2 Compare May 27, 2025 07:06
@lentzi90
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@mdbooth
Copy link
Contributor

mdbooth commented May 27, 2025

I see now where the new syntax came from 👍 Looks good to me when the tests are passing. Some issue with release artifacts in an old version?

@lentzi90
Copy link
Contributor Author

For some reason they decided to have versions without "v" in some places and with "v" in other places. And I am fumbling around figuring out where to put what 😂

@lentzi90 lentzi90 force-pushed the lentzi90/e2e-update branch from 6c9f9b2 to f22a626 Compare May 27, 2025 08:52
@lentzi90
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@lentzi90 lentzi90 force-pushed the lentzi90/e2e-update branch from f22a626 to a696906 Compare May 27, 2025 09:28
@lentzi90
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@lentzi90
Update e2e config and clusterctl-upgrade
c20ed8d 
This updates mostly the clusterctl-upgrade e2e test.
We make use of new functionality in the CAPI framework to calculate the latest patch releases instead of hard-coding them.
The upgrade start from CAPI v1.9 instead of v1.6, to keep the tested versions within supported releases.
Similarly CAPO upgrades from v0.11. Also an upgrade from v0.12 to main is added.

Signed-off-by: Lennart Jern <[email protected]>
@lentzi90 lentzi90 force-pushed the lentzi90/e2e-update branch from a696906 to c20ed8d Compare May 27, 2025 10:25
@lentzi90
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@lentzi90
Copy link
Contributor Author

It took some time but I managed to get all the "v"s in correct places.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2025
@EmilienM
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6565445 into kubernetes-sigs:main May 27, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from Inbox to Done in CAPO Roadmap May 27, 2025
@lentzi90 lentzi90 deleted the lentzi90/e2e-update branch May 27, 2025 12:39
@lentzi90 lentzi90 mentioned this pull request May 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilienM EmilienM Awaiting requested review from EmilienM

@mdbooth mdbooth Awaiting requested review from mdbooth

Assignees

@EmilienM EmilienM

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
CAPO Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lentzi90 @mdbooth @EmilienM @k8s-ci-robot