Skip to content

✨ feat: update ORC to v2 #2506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

✨ feat: update ORC to v2 #2506

merged 1 commit into from
Apr 7, 2025

Conversation

EmilienM
Copy link
Contributor

@EmilienM EmilienM commented Apr 2, 2025

What this PR does / why we need it:

Update ORC to v2

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 2, 2025
@k8s-ci-robot k8s-ci-robot requested review from lentzi90 and mdbooth April 2, 2025 13:26
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 2, 2025
@EmilienM EmilienM marked this pull request as draft April 2, 2025 13:26
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2025
@EmilienM EmilienM requested a review from mandre April 2, 2025 13:26
@netlify Netlify
Copy link

netlify bot commented Apr 2, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 1b491d8
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/67efcdc4c10dd80008c0ddee
😎 Deploy Preview https://deploy-preview-2506--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EmilienM EmilienM changed the title Update ORC to v2 ✨ feat: update ORC to v2 Apr 2, 2025
mandre
mandre reviewed Apr 2, 2025
View reviewed changes
@EmilienM EmilienM marked this pull request as ready for review April 2, 2025 16:40
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2025
@EmilienM
Copy link
Contributor Author

EmilienM commented Apr 2, 2025

/test

@k8s-ci-robot
Copy link
Contributor

@EmilienM: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-openstack-build

/test pull-cluster-api-provider-openstack-e2e-test

/test pull-cluster-api-provider-openstack-test

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-openstack-conformance-test

/test pull-cluster-api-provider-openstack-e2e-full-test

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-openstack-build

pull-cluster-api-provider-openstack-e2e-test

pull-cluster-api-provider-openstack-test

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@EmilienM
Copy link
Contributor Author

EmilienM commented Apr 2, 2025

/test pull-cluster-api-provider-openstack-e2e-full-test

@EmilienM EmilienM force-pushed the orc_v2 branch 2 times, most recently from be3cee2 to 78b810d Compare April 2, 2025 17:12
@EmilienM
Copy link
Contributor Author

EmilienM commented Apr 2, 2025

/test pull-cluster-api-provider-openstack-e2e-full-test

lentzi90
lentzi90 reviewed Apr 3, 2025
View reviewed changes
@EmilienM
Copy link
Contributor Author

EmilienM commented Apr 4, 2025

/test pull-cluster-api-provider-openstack-e2e-full-test

@EmilienM
Copy link
Contributor Author

EmilienM commented Apr 4, 2025

/test pull-cluster-api-provider-openstack-e2e-full-test

@EmilienM
Copy link
Contributor Author

EmilienM commented Apr 4, 2025

Please review again

mandre
mandre reviewed Apr 7, 2025
View reviewed changes
Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2025
lentzi90
lentzi90 reviewed Apr 7, 2025
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit 11da34c into kubernetes-sigs:main Apr 7, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from Inbox to Done in CAPO Roadmap Apr 7, 2025
@mandre mandre deleted the orc_v2 branch April 7, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@mdbooth mdbooth Awaiting requested review from mdbooth

+1 more reviewer

@mandre mandre mandre left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@mandre mandre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
CAPO Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@EmilienM @k8s-ci-robot @mandre @mdbooth @lentzi90