Skip to content

🌱 ci: build e2e prerequisites in parallel #2479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2025

Conversation

mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Mar 14, 2025

With this change we build the prerequisites of the e2e tests in parallel with the devstack build. We also upload the e2e image to devstack while devstack is still building, as soon as SSH is available.

This seems to result in an approximately 10 minute speed-up.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2025
@k8s-ci-robot k8s-ci-robot requested a review from EmilienM March 14, 2025 17:41
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 14, 2025
@k8s-ci-robot k8s-ci-robot requested a review from lentzi90 March 14, 2025 17:41
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 14, 2025
Copy link

netlify bot commented Mar 14, 2025

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 752dea6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/67d4c6ceabe9c300083b03d9
😎 Deploy Preview https://deploy-preview-2479--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdbooth mdbooth force-pushed the concurrent-e2e-image branch from d1f0813 to aa125cf Compare March 14, 2025 17:47
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 14, 2025
@mdbooth mdbooth force-pushed the concurrent-e2e-image branch 6 times, most recently from 55af120 to e520f42 Compare March 14, 2025 23:42
@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 14, 2025

@EmilienM @lentzi90 That last run finished in 54 minutes.

Prior test runs excluding ones from this PR have been:

  • 65
  • 68
  • 64
  • 68
  • 70
  • 65
  • 63

So there's a fair bit of variation there, but 54 minutes is definitely a chunk faster. What do you think?

@mdbooth mdbooth changed the title ci: build e2e-image in parallel ci: build e2e prerequisites in parallel Mar 14, 2025
@mdbooth mdbooth force-pushed the concurrent-e2e-image branch 2 times, most recently from 0c42665 to 4eb647f Compare March 14, 2025 23:52
With this change we build the prerequisites of the e2e tests in parallel
with the devstack build. We also upload the e2e image to devstack while
devstack is still building, as soon as SSH is available.
@mdbooth mdbooth force-pushed the concurrent-e2e-image branch from 4eb647f to 752dea6 Compare March 15, 2025 00:16
@EmilienM
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2025
@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 15, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2025
@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 15, 2025

For good measure:

/test pull-cluster-api-provider-openstack-e2e-test
/test pull-cluster-api-provider-openstack-e2e-full-test

@EmilienM
Copy link
Contributor

/lgtm
ship it, nice job!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1e5698d into kubernetes-sigs:main Mar 15, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from Inbox to Done in CAPO Roadmap Mar 15, 2025
@mdbooth mdbooth deleted the concurrent-e2e-image branch March 17, 2025 09:34
@lentzi90
Copy link
Contributor

/retitle 🌱 ci: build e2e prerequisites in parallel

@k8s-ci-robot k8s-ci-robot changed the title ci: build e2e prerequisites in parallel 🌱 ci: build e2e prerequisites in parallel Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants