Skip to content

Conversation

EmilienM
Copy link
Contributor

@EmilienM EmilienM commented Mar 5, 2025

What this PR does / why we need it:

Add a new GH action to periodically bump the golangci-lint when a new tag is available.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 5, 2025
@k8s-ci-robot k8s-ci-robot requested review from lentzi90 and mdbooth March 5, 2025 13:56
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 5, 2025
Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit f443c37
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/67c8583dd9c112000887b9be
😎 Deploy Preview https://deploy-preview-2450--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EmilienM EmilienM force-pushed the update-golangci-lint branch from 87cd3ba to f443c37 Compare March 5, 2025 13:57
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!
I was going to say that we could use renovate for these things, but honestly this simple workflow is easier to understand and debug.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2025
@EmilienM
Copy link
Contributor Author

EmilienM commented Mar 5, 2025

wait let me check renovate first!

@EmilienM
Copy link
Contributor Author

EmilienM commented Mar 5, 2025

Sounds like renovate is not allowed in the kubernetes-sigs organization, I sent a request but I suggest we don't wait. If it's authorized we might use it. This simple workflow would do the job now. Moreover, we might have additional bumps we want to make over time.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit 74a5888 into kubernetes-sigs:main Mar 5, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from Inbox to Done in CAPO Roadmap Mar 5, 2025
@EmilienM EmilienM deleted the update-golangci-lint branch March 5, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants